standardize the tslint:disable comments

cypress-io · Dec 18, 2024 · dd574ba · dd574ba
1 parent 9db9e96
commit dd574ba
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 11 deletions.
diff --git a/packages/app/src/composables/useSpecFilter.ts b/packages/app/src/composables/useSpecFilter.ts
@@ -35,7 +35,7 @@ export function useSpecFilter (savedFilter?: string) {
   })
 
   // initialize spec filter in store
-  // tslint:disable:no-floating-promises TODO: look at this
+  // tslint:disable:no-floating-promises
   setSpecFilter(specFilterModel.value)
 
   return {

diff --git a/packages/app/src/runs/useProjectRuns.ts b/packages/app/src/runs/useProjectRuns.ts
@@ -90,7 +90,7 @@ export const useProjectRuns = (online: Ref<boolean>): RunsComposable => {
   function startPolling () {
     timeout = window.setTimeout(function fetchNewerRuns () {
       if (variables.value && online.value) {
-        /* tslint:disable:no-floating-promises TODO: promise should be handled */
+        // tslint:disable:no-floating-promises
         refetcher.executeMutation(variables.value)
         .then(() => {
           startPolling()

diff --git a/packages/driver/src/cy/net-stubbing/events/before-request.ts b/packages/driver/src/cy/net-stubbing/events/before-request.ts
@@ -49,7 +49,7 @@ export const onBeforeRequest: HandlerFn<CyHttpMessages.IncomingRequest> = (Cypre
 
     debug('created request subscription %o', { eventName, request, subscription, handler })
 
-    // tslint:disable-next-line:no-floating-promises
+    // tslint:disable:no-floating-promises
     emitNetEvent('subscribe', { requestId, subscription } as NetEvent.ToServer.Subscribe)
   }
 
@@ -166,7 +166,7 @@ export const onBeforeRequest: HandlerFn<CyHttpMessages.IncomingRequest> = (Cypre
       queryObj = createQueryObject()
       queryProxy = createQueryProxy(queryObj)
     },
-    // tslint:disable-next-line:no-floating-promises
+    // tslint:disable:no-floating-promises
     on (eventName, handler) {
       if (!validEvents.includes(eventName)) {
         $errUtils.throwErrByPath('net_stubbing.request_handling.unknown_event', {
@@ -181,7 +181,7 @@ export const onBeforeRequest: HandlerFn<CyHttpMessages.IncomingRequest> = (Cypre
         $errUtils.throwErrByPath('net_stubbing.request_handling.event_needs_handler')
       }
 
-      // tslint:disable-next-line:no-floating-promises
+      // tslint:disable:no-floating-promises
       subscribe(eventName, handler)
 
       return userReq
@@ -206,7 +206,7 @@ export const onBeforeRequest: HandlerFn<CyHttpMessages.IncomingRequest> = (Cypre
       }
 
       // allow `req` to be sent outgoing, then pass the response body to `responseHandler`
-      // tslint:disable-next-line:no-floating-promises
+      // tslint:disable:no-floating-promises
       subscribe('response:callback', responseHandler)
 
       return finish(true)

diff --git a/packages/driver/src/cy/net-stubbing/events/index.ts b/packages/driver/src/cy/net-stubbing/events/index.ts
@@ -56,7 +56,7 @@ export function registerEvents (Cypress: Cypress.Cypress, cy: Cypress.cy) {
   }
 
   function sendStaticResponse (requestId: string, staticResponse: StaticResponse) {
-    // tslint:disable-next-line:no-floating-promises
+    // tslint:disable:no-floating-promises
     emitNetEvent('send:static:response', {
       requestId,
       staticResponse: getBackendStaticResponse(staticResponse),
@@ -94,7 +94,7 @@ export function registerEvents (Cypress: Cypress.Cypress, cy: Cypress.cy) {
       if (!route) {
         if (frame.subscription.await) {
           // route not found, just resolve so the request can continue
-          // tslint:disable-next-line:no-floating-promises
+          // tslint:disable:no-floating-promises
           emitResolved(frame.data)
         }
 

diff --git a/packages/frontend-shared/src/gql-components/composables/useCohorts.ts b/packages/frontend-shared/src/gql-components/composables/useCohorts.ts
@@ -78,7 +78,7 @@ export const useCohorts = () => {
         cohortOptionSelected.value = options.find((option) => option.cohort === cohortSelected.data?.determineCohort?.cohort)
       }
 
-      // tslint:disable-next-line:no-floating-promises TODO: This should be awaiting the fetchCohort call
+      // // tslint:disable:no-floating-promises
       fetchCohort()
     }
 

diff --git a/packages/icons/scripts/build.ts b/packages/icons/scripts/build.ts
@@ -24,5 +24,5 @@ async function build () {
   await fs.remove(iconsetPath)
 }
 
-/* tslint:disable:no-floating-promises TODO: look at this */
+// tslint:disable:no-floating-promises
 build()
diff --git a/packages/icons/scripts/ico.ts b/packages/icons/scripts/ico.ts
@@ -11,7 +11,7 @@ const files = [
   fs.readFileSync('./assets/icons/icon_256x256.png'),
 ]
 
-/* tslint:disable:no-floating-promises TODO: look at this */
+// tslint:disable:no-floating-promises
 toIco(files).then((buf) => {
   fs.writeFileSync('./dist/icons/cypress.ico', buf)
 })