fix: update tsconfig files to match previous config (#30856)

cypress-io · Jan 13, 2025 · ab2f0c1 · ab2f0c1 · cypress-bot · Jan 13, 2025
1 parent a46c2dd
commit ab2f0c1
Show file tree

Hide file tree

Showing 15 changed files with 41 additions and 10 deletions.
diff --git a/cli/CHANGELOG.md b/cli/CHANGELOG.md
@@ -55,6 +55,7 @@ in this [GitHub issue](https://github.com/cypress-io/cypress/issues/30447). Addr
 - Fixed a visibility issue for elements with `textContent` but without a width or height. Fixed in [#29688](https://github.com/cypress-io/cypress/pull/29688). Fixes [#29687](https://github.com/cypress-io/cypress/issues/29687).
 - Elements whose parent elements has `overflow: clip` and no height/width will now correctly show as hidden. Fixed in [#29778](https://github.com/cypress-io/cypress/pull/29778). Fixes [#23852](https://github.com/cypress-io/cypress/issues/23852).
 - The CSS pseudo-class `:dir()` is now supported when testing in Electron. Addresses [#29766](https://github.com/cypress-io/cypress/issues/29766).
+- Fixed an issue where the spec filename was not updating correctly when changing specs in `open` mode. Fixes [#30852](https://github.com/cypress-io/cypress/issues/30852).
 
 **Misc:**
 

diff --git a/packages/app/cypress/e2e/specs_list_e2e.cy.ts b/packages/app/cypress/e2e/specs_list_e2e.cy.ts
@@ -127,6 +127,26 @@ describe('App: Spec List (E2E)', () => {
       cy.findByTestId('runnable-header').should('be.visible')
     })
 
+    it('updates the spec filename when a new spec is selected', () => {
+      // load the first spec
+      cy.findAllByTestId('spec-item-link').contains('accounts_list.spec.js').click()
+
+      // ensure the tests are loaded
+      cy.contains('[aria-controls=reporter-inline-specs-list]', 'Specs')
+      cy.findByText('Your tests are loading...').should('not.be.visible')
+
+      // open the inline spec list
+      cy.get('body').type('f')
+
+      // verify the first spec filename
+      cy.findByTestId('runnable-header').contains('accounts_list.spec.js')
+
+      // select the second spec from the inline spec list
+      cy.findAllByTestId('spec-file-item').contains('accounts_new.spec.js').click()
+      // verify the spec filename was updated
+      cy.findByTestId('runnable-header').contains('accounts_new.spec.js')
+    })
+
     it('cannot open the Spec File Row link in a new tab with "cmd + click"', (done) => {
       let numTargets
       let newNumTargets

diff --git a/packages/app/tsconfig.json b/packages/app/tsconfig.json
@@ -13,13 +13,15 @@
   ],
   "compilerOptions": {
     "noImplicitThis": true,
+    "useDefineForClassFields": true,
     "paths": {
       "@cy/i18n": ["../frontend-shared/src/locales/i18n"],
       "@cy/components/*": ["../frontend-shared/src/components/*"],
       "@cy/gql-components/*": ["../frontend-shared/src/gql-components/*"],
       "@cy/store/*": ["../frontend-shared/src/store/*"],
       "@packages/*": ["../*"]
     },
+    "allowJs": true,
     "types": [
       "cypress", 
       "cypress-real-events", 

diff --git a/packages/config/tsconfig.json b/packages/config/tsconfig.json
@@ -10,9 +10,10 @@
     "allowJs": false,
     "rootDir": "src",
     "noImplicitAny": true,
+    "noUncheckedIndexedAccess": true,
     "types": ["node"],
     "typeRoots": [
       "../../node_modules/@types"
     ],
   }
-}
+}
diff --git a/packages/data-context/tsconfig.json b/packages/data-context/tsconfig.json
@@ -11,6 +11,7 @@
     "lib": ["esnext"],
     "allowJs": false,
     "noImplicitAny": true,
+    "noUncheckedIndexedAccess": true,
     "types": ["cypress"],
   }
-}
+}
diff --git a/packages/driver/tsconfig.json b/packages/driver/tsconfig.json
@@ -9,7 +9,6 @@
     "preserveWatchOutput": true,
     "sourceMap": true,
     "strictNullChecks": true,
-    "forceConsistentCasingInFileNames": true,
     "noEmit": true,
     "outDir": "dist",
     "noErrorTruncation": true,

diff --git a/packages/errors/tsconfig.json b/packages/errors/tsconfig.json
@@ -7,5 +7,6 @@
     "allowJs": false,
     "noImplicitAny": true,
     "noImplicitReturns": false,
+    "noUncheckedIndexedAccess": true,
   }
-}
+}
diff --git a/packages/extension/tsconfig.json b/packages/extension/tsconfig.json
@@ -2,6 +2,7 @@
   "extends": "../ts/tsconfig.json",
   "compilerOptions": {
     "target": "es2015",
+    "allowJs": true,
     "strict": false
   }
 }
diff --git a/packages/graphql/src/utils/nexusTypegenUtils.ts b/packages/graphql/src/utils/nexusTypegenUtils.ts
@@ -92,7 +92,7 @@ const nexusTypegenDebounced = (cfg: NexusTypegenCfg) => {
   debounced[cfg.filePath] =
     debounced[cfg.filePath] ?? _.debounce(nexusTypegen, 500)
 
-  debounced[cfg.filePath](cfg)
+  debounced[cfg.filePath]?.(cfg)
 }
 
 interface NexusTypegenWatchCfg extends NexusTypegenCfg {

diff --git a/packages/graphql/tsconfig.json b/packages/graphql/tsconfig.json
@@ -12,6 +12,7 @@
     "lib": ["esnext"],
     "allowJs": false,
     "noImplicitAny": true,
+    "noUncheckedIndexedAccess": true,
     "types": []
   },
 }
diff --git a/packages/icons/tsconfig.json b/packages/icons/tsconfig.json
@@ -3,6 +3,7 @@
   "compilerOptions": {
     "allowJs": false,
     "noImplicitAny": true,
+    "noUncheckedIndexedAccess": true,
     "outDir": "dist",
   },
-}
+}
diff --git a/packages/reporter/tsconfig.json b/packages/reporter/tsconfig.json
@@ -1,6 +1,7 @@
 {
   "extends": "../ts/tsconfig.json",
   "compilerOptions": {
+    "useDefineForClassFields": true,
     "types": [
       "node",
       "cypress",

diff --git a/packages/scaffold-config/tsconfig.json b/packages/scaffold-config/tsconfig.json
@@ -12,6 +12,7 @@
     "lib": ["esnext"],
     "allowJs": false,
     "noImplicitAny": true,
+    "noUncheckedIndexedAccess": true,
     "types": []
   }
-}
+}
diff --git a/packages/telemetry/tsconfig.json b/packages/telemetry/tsconfig.json
@@ -6,6 +6,7 @@
     "lib": ["esnext", "DOM"],
     "allowJs": false,
     "noImplicitAny": true,
+    "noUncheckedIndexedAccess": true,
     "types": ["cypress"],
   }
 }
diff --git a/packages/ts/tsconfig.json b/packages/ts/tsconfig.json
@@ -24,7 +24,7 @@
     // "useDefineForClassFields": true,                  /* Emit ECMAScript-standard-compliant class fields. */
     // "moduleDetection": "auto",                        /* Control what method is used to detect module-format JS files. */
 
-        /* Modules */
+    /* Modules */
     "module": "commonjs",                                /* Specify what module code is generated. */
     // "rootDir": "./",                                  /* Specify the root folder within your source files. */
     "moduleResolution": "node",                          /* Specify how TypeScript looks up a file from a given module specifier. */
@@ -98,8 +98,8 @@
     "noUnusedLocals": false,                             /* Enable error reporting when local variables aren't read. */
     "noUnusedParameters": false,                         /* Raise an error when a function parameter isn't read. */
     // "exactOptionalPropertyTypes": true,               /* Interpret optional property types as written, rather than adding 'undefined'. */
-    // "noImplicitReturns": true,                        /* Enable error reporting for codepaths that do not explicitly return in a function. */
-    // "noFallthroughCasesInSwitch": true,               /* Enable error reporting for fallthrough cases in switch statements. */
+    "noImplicitReturns": true,                           /* Enable error reporting for codepaths that do not explicitly return in a function. */
+    "noFallthroughCasesInSwitch": true,                  /* Enable error reporting for fallthrough cases in switch statements. */
     // "noUncheckedIndexedAccess": true,                 /* Add 'undefined' to a type when accessed using an index. */
     // "noImplicitOverride": true,                       /* Ensure overriding members in derived classes are marked with an override modifier. */
     // "noPropertyAccessFromIndexSignature": true,       /* Enforces using indexed accessors for keys declared using an indexed type. */