moving verify icons custom command

cypress-io · Jan 6, 2025 · a7bf68d · a7bf68d
1 parent 56a578a
commit a7bf68d
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 3 deletions.
diff --git a/packages/app/cypress/component/support/ctSupport.ts b/packages/app/cypress/component/support/ctSupport.ts
@@ -1,6 +1,5 @@
 import { AutIframe } from '../../../src/runner/aut-iframe'
 import { EventManager } from '../../../src/runner/event-manager'
-import '../../e2e/support/browserIconCommands'
 import type { Socket } from '@packages/socket/lib/browser'
 
 export const StubWebsocket = new Proxy<Socket>(Object.create(null), {

diff --git a/packages/app/cypress/e2e/support/e2eSupport.ts b/packages/app/cypress/e2e/support/e2eSupport.ts
@@ -1,5 +1,4 @@
 import '@packages/frontend-shared/cypress/support/e2e'
-import './browserIconCommands'
 import 'cypress-real-events/support'
 import './execute-spec'
 

diff --git a/...ypress/e2e/support/browserIconCommands.ts → ...ed/cypress/support/browserIconCommands.ts b/...ypress/e2e/support/browserIconCommands.ts → ...ed/cypress/support/browserIconCommands.ts
diff --git a/packages/frontend-shared/cypress/support/component.ts b/packages/frontend-shared/cypress/support/component.ts
@@ -3,6 +3,7 @@ import { registerMountFn, addVueCommand } from './common'
 import '../../src/styles/shared.scss'
 import 'tailwindcss/tailwind.css'
 import 'cypress-real-events/support'
+import './browserIconCommands'
 import { installCustomPercyCommand } from './customPercyCommand'
 import { addNetworkCommands } from './onlineNetwork'
 import { GQLStubRegistry } from './mock-graphql/stubgql-Registry'

diff --git a/packages/frontend-shared/cypress/support/e2e.ts b/packages/frontend-shared/cypress/support/e2e.ts
@@ -19,6 +19,7 @@ import i18n from '../../src/locales/en-US.json'
 import { addNetworkCommands } from './onlineNetwork'
 import { logInternal } from './utils'
 import { tabUntil } from './tab-until'
+import './browserIconCommands'
 
 configure({ testIdAttribute: 'data-cy' })
 

diff --git a/packages/launchpad/src/setup/OpenBrowserList.cy.tsx b/packages/launchpad/src/setup/OpenBrowserList.cy.tsx
@@ -2,6 +2,7 @@ import { OpenBrowserListFragmentDoc } from '../generated/graphql-test'
 import OpenBrowserList from './OpenBrowserList.vue'
 import { longBrowsersList } from '@packages/frontend-shared/cypress/support/mock-graphql/longBrowsersList'
 import { defaultMessages } from '@cy/i18n'
+import { cyGeneralGlobeX16 } from '@cypress-design/icon-registry'
 
 // Testing Note: because state for this component is maintained on the server and updated via gql mutations,
 // this component test can't do interactions that change the chosen browser at the moment. Interactions and states
@@ -31,7 +32,7 @@ describe('<OpenBrowserList />', () => {
 
     // Renders a default logo if we don't provide one
     cy.get('[data-cy-browser="fake"]').should('have.attr', 'aria-disabled', 'true')
-    cy.get('[data-cy-browser="fake"] img').should('have.attr', 'src').should('include', 'generic-browser')
+    cy.get('[data-cy-browser="fake"] svg').eq(0).children().verifyBrowserIconSvg(cyGeneralGlobeX16.data)
 
     cy.percySnapshot()
   })