Fix issue with CT not mounting correctly with comments within it

cypress-io · Dec 18, 2024 · 498080a · 498080a
1 parent 3f5dff5
commit 498080a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/frontend-shared/src/composables/examples/UseCohortsExample.vue b/packages/frontend-shared/src/composables/examples/UseCohortsExample.vue
@@ -1,6 +1,5 @@
 <template>
   <div data-cy="result">
-    <!-- @vue-expect-error TODO: this promise is not being awaited properly -->
     {{ cohortChoice?.value }}
   </div>
 </template>

diff --git a/packages/frontend-shared/src/gql-components/composables/useCohorts.ts b/packages/frontend-shared/src/gql-components/composables/useCohorts.ts
@@ -61,7 +61,7 @@ export const useCohorts = () => {
    *
    * @returns a reactive reference to the cohort option that is selected
    */
-  const getCohort = async (config: CohortConfig) => {
+  const getCohort = (config: CohortConfig) => {
     const cohortOptionSelected = ref<CohortOption>()
 
     const { name, options } = config
@@ -78,7 +78,8 @@ export const useCohorts = () => {
         cohortOptionSelected.value = options.find((option) => option.cohort === cohortSelected.data?.determineCohort?.cohort)
       }
 
-      await fetchCohort()
+      // ts-disable:no-floating-promises TODO: This should be awaiting the fetchCohort call
+      fetchCohort()
     }
 
     return cohortOptionSelected