remove requireRestartOnChange for defaultBrowser, prevent bad open mo…

…de behavior (#9) * Update options.ts * Update DataContext.ts
cypress-io · Nov 8, 2024 · 2a53ba0 · 2a53ba0
1 parent 6933638
commit 2a53ba0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/config/src/options.ts b/packages/config/src/options.ts
@@ -184,7 +184,6 @@ const driverConfigOptions: Array<DriverConfigOption> = [
     defaultValue: 'cypress/downloads',
     validation: validate.isString,
     isFolder: true,
-    requireRestartOnChange: 'browser',
   }, {
     name: 'e2e',
     // e2e runner overrides

diff --git a/packages/data-context/src/DataContext.ts b/packages/data-context/src/DataContext.ts
@@ -427,7 +427,10 @@ export class DataContext {
   }
 
   updateCliBrowser (browser: string) {
-    (this._modeOptions as Partial<AllModeOptions>).browser = browser
-    this.coreData.cliBrowser = browser
+    // in open mode, prevent cliBrowser from being changed after browser is opened
+    if (this.isRunMode || !this.coreData.cliBrowser) {
+      (this._modeOptions as Partial<AllModeOptions>).browser = browser
+      this.coreData.cliBrowser = browser
+    }
   }
 }