Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Auth0 tests to use experimentalSessionAndOrigin #1270

Merged
merged 6 commits into from
Nov 28, 2022

Conversation

debrisapron
Copy link
Contributor

Closes #1247

This change updates the Auth0 login tests to use cy.origin and cy.session instead of programmatic login.

Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing things like this makes me happy 😄 !

cypress/support/auth-provider-commands/auth0.ts Outdated Show resolved Hide resolved
@debrisapron debrisapron force-pushed the convert-auth0-tests-to-cy-origin branch from cda9531 to eadad09 Compare September 6, 2022 21:45
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 89.68% // Head: 89.68% // No change to project coverage 👍

Coverage data is based on head (ca4aff0) compared to base (40b458e).
Patch has no changes to coverable lines.

❗ Current head ca4aff0 differs from pull request most recent head a1637f6. Consider uploading reports for the commit a1637f6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1270   +/-   ##
========================================
  Coverage    89.68%   89.68%           
========================================
  Files           19       19           
  Lines          737      737           
  Branches        35       35           
========================================
  Hits           661      661           
  Misses          76       76           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cypress
Copy link

cypress bot commented Sep 27, 2022



Test summary

295 0 0 0


Run details

Project cypress-realworld-app
Status Passed
Commit a1637f6
Started Nov 23, 2022 8:30 PM
Ended Nov 23, 2022 8:47 PM
Duration 17:09 💡
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

mjhenkes
mjhenkes previously approved these changes Sep 28, 2022
@AtofStryker AtofStryker requested review from AtofStryker and removed request for robertguss September 28, 2022 16:58
@debrisapron
Copy link
Contributor Author

Updated for changes to cy.session and cy.origin APIs. I think this resolves all my issues with the validate callback, the code is much clearer now.

src/containers/AppAuth0.tsx Show resolved Hide resolved
@debrisapron debrisapron merged commit 9f5e487 into develop Nov 28, 2022
@emilyrohrbough emilyrohrbough deleted the convert-auth0-tests-to-cy-origin branch March 28, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cy.origin examples to RWA
4 participants