Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update factory example and ARG test browser versions #1279

Merged
merged 1 commit into from
Jan 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions factory/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,23 +66,23 @@ Example: `CYPRESS_VERSION='13.11.0'`

The version of Chrome to install. If the `ARG` variable is unset or an empty string, Chrome is not installed. The exact version must be used, no wildcards or shorthands are supported.

Example: `CHROME_VERSION='125.0.6422.141-1'`
Example: `CHROME_VERSION='131.0.6778.264-1'`

[Chrome versions](https://www.ubuntuupdates.org/package/google_chrome/stable/main/base/google-chrome-stable)

### FIREFOX_VERSION

The version of Firefox to install. If the `ARG` variable is unset or an empty string, Firefox is not installed. The exact version must be used, no wildcards or shorthands are supported.

Example: `FIREFOX_VERSION='126.0.1'`
Example: `FIREFOX_VERSION='134.0'`

[Firefox versions](https://download-installer.cdn.mozilla.net/pub/firefox/releases/)

### EDGE_VERSION

The version of Edge to install. If the `ARG` variable is unset or an empty string, Edge is not installed. The exact version must be used, no wildcards or shorthands are supported.

Example: `EDGE_VERSION='125.0.2535.85-1'`
Example: `EDGE_VERSION='131.0.2903.112-1'`

[Edge versions](https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/)

Expand Down Expand Up @@ -136,9 +136,9 @@ Create a `Dockerfile` with the following content:
# Args are defined in the Dockerfile before the FROM command.
# Using these args will cause an image to be created with
# Node.js (default version from .env file), Chrome, Firefox and Edge.
ARG CHROME_VERSION='125.0.6422.141-1'
ARG EDGE_VERSION='125.0.2535.85-1'
ARG FIREFOX_VERSION='126.0.1'
ARG CHROME_VERSION='131.0.6778.264-1'
ARG EDGE_VERSION='131.0.2903.112-1'
ARG FIREFOX_VERSION='134.0'

FROM cypress/factory

Expand Down Expand Up @@ -173,7 +173,7 @@ RUN npx cypress install
Run the Docker commands:

```bash
docker build . --build-arg CHROME_VERSION='125.0.6422.141-1' --build-arg EDGE_VERSION='125.0.2535.85-1' --build-arg FIREFOX_VERSION='126.0.1' -t test
docker build . --build-arg CHROME_VERSION='131.0.6778.264-1' --build-arg EDGE_VERSION='131.0.2903.112-1' --build-arg FIREFOX_VERSION='134.0' -t test
docker run -it --rm test npx cypress run -b chrome
```

Expand Down Expand Up @@ -222,7 +222,7 @@ Since this example only uses Chrome, removing Edge and Firefox is as simple as n
Create a `Dockerfile` with the following content:

```dockerfile
ARG CHROME_VERSION='125.0.6422.141-1'
ARG CHROME_VERSION='131.0.6778.264-1'
FROM cypress/factory
Expand Down
6 changes: 3 additions & 3 deletions factory/test-project/argsDefined.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Args are defined in the Dockerfile before the FROM command.
ARG CHROME_VERSION='126.0.6478.114-1'
ARG EDGE_VERSION='126.0.2592.61-1'
ARG FIREFOX_VERSION='128.0'
ARG CHROME_VERSION='131.0.6778.264-1'
ARG EDGE_VERSION='131.0.2903.112-1'
ARG FIREFOX_VERSION='134.0'

ARG BASE_TEST_IMAGE='cypress/factory'

Expand Down