Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump node version to 20.8.1 #951

Merged
merged 2 commits into from
Oct 24, 2023
Merged

chore: bump node version to 20.8.1 #951

merged 2 commits into from
Oct 24, 2023

Conversation

Julien-Marcou
Copy link
Contributor

@Julien-Marcou Julien-Marcou commented Oct 19, 2023

Bump default node version from v20.6.1 to v20.8.1 as it is a security release (and the new LTS since October 24):

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2023

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link

@MikeMcC399
Copy link
Collaborator

For previous changes to Node.js, the FACTORY_VERSION was bumped

# Update this to deploy the docker factory if you make changes to factory.Dockerfile or install scripts
FACTORY_VERSION='3.1.0'

and a corresponding entry was made into the CHANGELOG.md

28 CircleCI tests are failing, so this would need to be looked at.

@Julien-Marcou
Copy link
Contributor Author

Julien-Marcou commented Oct 20, 2023

For previous changes to Node.js, the FACTORY_VERSION was bumped

# Update this to deploy the docker factory if you make changes to factory.Dockerfile or install scripts
FACTORY_VERSION='3.1.0'

and a corresponding entry was made into the CHANGELOG.md

28 CircleCI tests are failing, so this would need to be looked at.

@MikeMcC399

I'm not sure, but I think the FACTORY_VERSION should only be updated when we want to release a new version, but it's not necessarily the case here, maybe the owners of this repository want to push more commits before releasing a new version.

But if you think I should bump the version, then I would be able to write the corresponding changelog for this new version 🙂

Regarding CircleCI, I took a look at it, and it looks the like the cURL requests where cancelled for some reason I'm not aware of, maybe just an unlucky timing with network issues, or maybe the pipelines were cancelled because it's useless until someone approves the PR? Anyway I can't restart them to try and dig deeper 😅

@MikeMcC399
Copy link
Collaborator

@Julien-Marcou

It would be best for you to wait for feedback from the Cypress team concerning next steps. I would not implement my suggestions until you have heard from them.

A workaround to re-trigger CircleCI is to amend your last commit (without making any other changes to it) and then force-pushing it to GitHub.

@MikeMcC399
Copy link
Collaborator

Node.js 20.8.1 is now the official LTS version according to https://nodejs.org, so this version should be made available for Cypress Docker images.

@Julien-Marcou
Copy link
Contributor Author

👍 considering that node 20.8.1 now is the new LTS, I think this new version should be made available quickly, so I've bumped the release version and added the corresponding changelog

It will be faster to revert the last commit before merging if we decide not to release this change, rather than adding it later if it's needed 😄

@mjhenkes mjhenkes self-requested a review October 24, 2023 12:28
@mjhenkes
Copy link
Member

@Julien-Marcou thanks for the update!

with regards to versioning, you're right we only want to update it when we release, but typically we release a new version with each change because it's so easy.

@mschile mschile merged commit be22332 into cypress-io:master Oct 24, 2023
@Julien-Marcou Julien-Marcou deleted the chore/deps-node-20-8-1 branch October 24, 2023 14:11
@MikeMcC399
Copy link
Collaborator

MikeMcC399 commented Oct 24, 2023

@mschile

I just saw that v20.9.0 has been tagged as the Node.js 20.x LTS, so if there are still problems publishing a v20.8.1 version, perhaps that should be abandoned, in favor of the LTS version, possibly also combined with the next release of Cypress if this is imminent? (The difference between the two versions is however purely documentary, not functional - see nodejs/node@v20.8.1...v20.9.0.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants