-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump node version to 20.8.1 #951
chore: bump node version to 20.8.1 #951
Conversation
|
For previous changes to Node.js, the cypress-docker-images/factory/.env Lines 16 to 17 in 7d5bad8
and a corresponding entry was made into the CHANGELOG.md 28 CircleCI tests are failing, so this would need to be looked at. |
I'm not sure, but I think the But if you think I should bump the version, then I would be able to write the corresponding changelog for this new version 🙂 Regarding CircleCI, I took a look at it, and it looks the like the cURL requests where cancelled for some reason I'm not aware of, maybe just an unlucky timing with network issues, or maybe the pipelines were cancelled because it's useless until someone approves the PR? Anyway I can't restart them to try and dig deeper 😅 |
It would be best for you to wait for feedback from the Cypress team concerning next steps. I would not implement my suggestions until you have heard from them. A workaround to re-trigger CircleCI is to amend your last commit (without making any other changes to it) and then force-pushing it to GitHub. |
Node.js |
👍 considering that node 20.8.1 now is the new LTS, I think this new version should be made available quickly, so I've bumped the release version and added the corresponding changelog It will be faster to revert the last commit before merging if we decide not to release this change, rather than adding it later if it's needed 😄 |
@Julien-Marcou thanks for the update! with regards to versioning, you're right we only want to update it when we release, but typically we release a new version with each change because it's so easy. |
I just saw that v20.9.0 has been tagged as the Node.js |
Bump default node version from v20.6.1 to v20.8.1 as it is a security release (and the new LTS since October 24):