-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fix for running cypress interactive UI from docker #1280
base: master
Are you sure you want to change the base?
Conversation
This includes changes that are necessary to run cypress from mac
|
Thanks for following up this issue from https://discord.com/channels/755913899261296641/1326943958479142913 ! |
This comment was marked as resolved.
This comment was marked as resolved.
The instructions on https://www.cypress.io/blog/run-cypress-with-a-single-docker-command are slightly different. Perhaps an independent macOS user could check that the new instructions on https://github.com/BountyHunter1999/cypress-docker-images/blob/patch-1/CONTRIBUTING.md#to-forward-x11-from-inside-a-docker-container-to-a-host-running-macos are correct? |
This happens when xhost is not set properly in the path
@BountyHunter1999 |
I just ensured that the value is interpolated in the setting rather than creating a variable outside. You can check that the command is similar. |
What about the instruction?
Where is |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jennifer-shehane
You have requested my review.
It is a documentation change only and as far as I can see from the text it looks fine.
I would however difficulty approving it, as it contains instructions for a macOS user and I don't have that environment to test on. I don't have any outstanding requests for change however. All my requests for change have been dealt with.
This includes changes that are necessary to run cypress from mac