Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for running cypress interactive UI from docker #1280

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

BountyHunter1999
Copy link

This includes changes that are necessary to run cypress from mac

This includes changes that are necessary to run cypress from mac
@CLAassistant
Copy link

CLAassistant commented Jan 14, 2025

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link

@MikeMcC399
Copy link
Collaborator

@BountyHunter1999

Thanks for following up this issue from https://discord.com/channels/755913899261296641/1326943958479142913 !

@MikeMcC399

This comment was marked as resolved.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@MikeMcC399
Copy link
Collaborator

This happens when xhost is not set properly in the path
@MikeMcC399
Copy link
Collaborator

@BountyHunter1999
It doesn't look like your instructions set the environment variable IP before you use it. Would you like to double-check? Perhaps I have misunderstood?

@BountyHunter1999
Copy link
Author

@BountyHunter1999 It doesn't look like your instructions set the environment variable IP before you use it. Would you like to double-check? Perhaps I have misunderstood?

xhost +$(ipconfig getifaddr en0)

I just ensured that the value is interpolated in the setting rather than creating a variable outside. You can check that the command is similar.

@MikeMcC399
Copy link
Collaborator

@BountyHunter1999

What about the instruction?

Set up a DISPLAY env var `export DISPLAY="$IP:0"

Where is $IP set?

@BountyHunter1999
Copy link
Author

@BountyHunter1999

What about the instruction?

Set up a DISPLAY env var `export DISPLAY="$IP:0"

Where is $IP set?

  • Yes, it seems that was missing. I tried not to create the IP variable, it was either that or enter this $(ipconfig getifaddr en0) in multiple places.
    I have added explicit IP assignment now

Copy link
Collaborator

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jennifer-shehane
You have requested my review.

It is a documentation change only and as far as I can see from the text it looks fine.

I would however difficulty approving it, as it contains instructions for a macOS user and I don't have that environment to test on. I don't have any outstanding requests for change however. All my requests for change have been dealt with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants