add new technology-magnifying-glass-no-results icons #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: c66790f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cypress-design
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress-design
|
| Branch Review |
add-no-results-icon
|
| Run status |
|
| Run duration | 02m 33s |
| Commit |
|
| Committer | Emily Rohrbough |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
222
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
11.36%
|
|
|---|---|
|
Untested elements
|
166
|
|
Tested elements
|
25
|
Accessibility
99.37%
|
|
|---|---|
|
Failed rules
|
0 critical
1 serious
0 moderate
1 minor
|
|
Failed elements
|
22
|
elevatebart
reviewed
Sep 16, 2024
There was a problem hiding this comment.
I will fix the colors a tad:
- The outline should be currentColor by default
- the bg should be transparent
- the cross should be
icon-dark-secondaryto be changed independently
I will do the changes, please validate once pushed.
There was a problem hiding this comment.
The secondary color class makes sense. It wasn't called out in the instructions for adding an icon so didn't realize it existed.
There was a problem hiding this comment.
Thank you @elevatebart !
- make defaults consistent - use transparent by default for fill
elevatebart
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Designs: https://www.figma.com/design/1WJ3GVQyMV5e7xVxPg3yID/Design-System?node-id=11874-19939&t=i1otvSaMbz52Q0E9-4