Fix compilation on 32bit architectures such as i386, armhf #34
Conversation
On those architectures, the tests fail to build with an overflow error: src/github.com/cyphar/filepath-securejoin/mkdir_linux_test.go:254:8: constant 2147484159 overflows int FAIL github.com/cyphar/filepath-securejoin [build failed] Turns out that FileMode is defined as an uint32 in the os.fs package. Since `MkdirAll` is intended as a replacement for os.MkdirAll, it makes sense to use the same types for all arguments, and that means os.FileMode for the mode parameter. Signed-off-by: Reinhard Tartler <[email protected]>
| @@ -22,6 +22,8 @@ var ( | |||
| errPossibleAttack = errors.New("possible attack detected") | |||
| ) | |||
|
|
|||
| type FileMode = os.FileMode | |||
There was a problem hiding this comment.
The problem with doing this (and this is the reason why I didn't use os.FileMode in the first place) is that the os.FileMode bits don't match the Unix bits outside of 0o777. Passing the wrong mode bits is a common bug and accepting os.FileMode would lead to confusion unless we also added conversion code as well. (To be fair, we would return an error in this case now, but I'd like to avoid these kinds of mistakes if possible.)
I think it would be simpler to just use uint32 instead (though looking it up, it seems the kernel actually defines umode_t as unsigned short which is uint16).
|
Given that libpathrs takes This will require a |
On those architectures, the tests fail to build with an overflow error:
src/github.com/cyphar/filepath-securejoin/mkdir_linux_test.go:254:8: constant 2147484159 overflows int FAIL
github.com/cyphar/filepath-securejoin [build failed]
Turns out that FileMode is defined as an uint32 in the os.fs package. Since
MkdirAllis intended as a replacement for os.MkdirAll, it makes sense to use the same types for all arguments, and that means os.FileMode for the mode parameter.