Increase initial WS timeout to try to mitigate slow connection problem #1684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subscriptions-transport-ws
uses an exponential backoff function to cancel and retry the WebSocket connection when it first connects. The default initial timeout is 1s - https://github.com/apollographql/subscriptions-transport-ws/blob/master/src/defaults.ts#L1I've increased it to 3s here to try and mitigate the slow initial connection problem #1200, though according to Oliver that problem may be caused by the connection closing unexpectedly (which triggers the WebSocket's
onclose
) rather than timing out (which doesn't). It's worth a shot anyway.Check List
CONTRIBUTING.md
and added my name as a Code Contributor.CHANGES.md
entry not included as we don't know if this fixes the problem