Functional tests: allow grep_fail to accept options
#6463
Conversation
tests/functional/cli/05-colour.t
Outdated
| # FIXME: this test doesn't work because of some interaction between the | ||
| # `script` command and colorama. The output includes a color reset char at | ||
| # the end despite using colorama.init(autoreset=False). | ||
| # script -q -c "cylc scan -t rich --color=never" log > /dev/null 2>&1 | ||
| # grep_fail "$ANSI" log -P # no color |
There was a problem hiding this comment.
This test wasn't testing what it was supposed to test before?
There was a problem hiding this comment.
No because the grep_fail function didn't use any of the options you provided
There was a problem hiding this comment.
Ok, we should link an issue to this FIXME.
Would this close it: #6076 ?
There was a problem hiding this comment.
No (I tried turning autoreset back on even though that wouldn't make any sense for it to fix the test, and it didn't help).
N.B. I had a look at how colorama works. It bills itself as a package meant only for making colour work on Windows, but I guess we are using it for its init(strip=not use_color) function that can automatically strip ANSI color chars from print() calls (it actually patches sys.stdout and sys.stderr). However there are >100 open issues and it is in a call-for-maintainers state: tartley/colorama#300.
|
Merging with 1.5 approvals... |
* upstream/master: Update cylc/flow/rundb.py GH Actions shortlog: check out head ref Add Paul Armstrong to CONTRIBUTING.md Report the error if write attempts fail to the DB Functional tests: allow `grep_fail` to accept options (cylc#6463) Bump dev version Prepare release 8.3.6 Bump pypa/gh-action-pypi-publish from 1.11.0 to 1.12.2 Simplify task state deltas Refactor task killing Bump pypa/gh-action-pypi-publish from 1.10.3 to 1.11.0 (cylc#6455) [skip ci] Spawn parentless sequential xtriggered task on set outputs (cylc#6448) Delete changes.d/6404.fix.md Pass pre-install plugins the value of workflow rundir as options.against source, allowing re-install and validate against source to access previous CLI opts as stored in rose-suite-cylc-install.conf
Like the description says. Split off from #6370
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.?.?.xbranch.