Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compatibility with PHP 8.4 #214

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Improve compatibility with PHP 8.4 #214

merged 2 commits into from
Dec 10, 2024

Conversation

roxblnfk
Copy link
Member

@roxblnfk roxblnfk commented Dec 10, 2024

🔍 What was changed

  • Fix deprecated nullable types

Related issue: #213

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.42%. Comparing base (bdb9d34) to head (3822f76).
Report is 4 commits behind head on 2.x.

Files with missing lines Patch % Lines
src/Driver/ReadonlyHandler.php 0.00% 1 Missing ⚠️
src/Query/Traits/JoinTrait.php 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                2.x     #214   +/-   ##
=========================================
  Coverage     95.42%   95.42%           
  Complexity     1866     1866           
=========================================
  Files           130      130           
  Lines          5204     5204           
=========================================
  Hits           4966     4966           
  Misses          238      238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roxblnfk roxblnfk merged commit a6b860e into 2.x Dec 10, 2024
24 of 26 checks passed
@roxblnfk roxblnfk deleted the php-8-4 branch December 10, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant