BasicAlertDialog実装 （テストなし） #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeda
reviewed
Aug 25, 2025
.../main/java/com/cybozu/sample/kintone/spaces/data/space/entity/CommentMessageForThreadBody.kt
Show resolved
Hide resolved
...src/main/java/com/cybozu/sample/kintone/spaces/feature/communicate/thread/ThreadViewModel.kt
Show resolved
Hide resolved
Comment on lines
+8
to
+11
| val isError: Boolean = false, | ||
| val isRefreshing: Boolean = false, | ||
| val isPosting: Boolean = false, | ||
| val isPostError: Boolean = false, |
Collaborator
There was a problem hiding this comment.
このままだと機能が増えるたびにエラーのフラグが増えていってしまうので、エラー状態の表現方法を工夫したほうがこの先コードが書きやすそうです。
例えば、enumやsealed class/interfaceで別のエラー型を作るとか？
Author
There was a problem hiding this comment.
memo: 改善案
sealed classでExceptionを継承したエラーハンドリング専用のクラスや、状態を表現するクラスを作り、それを適応する
戻り値で状態、エラーを表現する
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
最後の悪あがきです笑
よろしくお願いいたします。