Fix crash when accessing setValue concurrently (follow-up) #5
Conversation
|
Does |
hokuron
force-pushed
the
support-concurrently-access
branch
from
55f631f to
b02d093
Compare
I think it is unnecessary since it won't e needed if we upgrade the macOS version in GitHub Actions. What do you think? @ichiho-ojima |
| var storage: [CacheKey : Data] = [:] | ||
| let storage: ThreadSafeDictionary<CacheKey, Data> = .init() |
There was a problem hiding this comment.
I wonder if the crash issue cannot be resolved simply by wrapping storage with OSAllocatedUnfairLock.
There was a problem hiding this comment.
@ichiho-ojima
OSAllocatedUnfairLock requires iOS 16+, tvOS 16+, watchOS 9+, and macOS 13+. Can we bump our minimum deployment targets to these versions?
There was a problem hiding this comment.
Oops, I forgot to consider the version where OSAllocatedUnfairLock is available.
Personally, I think it's an option to make the supported version iOS 16+ for using OSAllocatedUnfairLock, but what do you think? @elmetal
There was a problem hiding this comment.
@ichiho-ojima
I think that's a good approach, but we need to be mindful of versioning.
Should we keep this PR focused on adding |
If migrating to Swift 6 is very straightforward, I think it would be fine to handle it in this PR. |
This is a follow-up PR to #2.
Closes #2