mark A/AAAA records as needing to be regenerated when address changes #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When editing an ipblock, the A/AAAA records are not being marked as needing to be regenerated - only their PTR (.arpa) zone gets marked. This commit fixes that issue.
|
Hey Carlos, I just reviewed some of the PRs in your Netdot repository. I see the PR that obsoletes HostAudit and replaces it with the SHA256 digests. It looks like that will take care of the bug we were hitting and that this PR was aimed at fixing. Thus your branch will most definitely make this PR wrong and useless. So... I guess you can ignore it or close it. I suppose I could close it, too, but it is a simple patch to fix the bug between now and when 1.1 gets released. PS. Any idea on what the roadmap looks like for the next release? Thanks, -m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing an ipblock, the A/AAAA records are not being marked as
needing to be regenerated - only their PTR (.arpa) zone gets marked.
This commit fixes that issue.