-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fanart_height option #41
Open
hjbotha
wants to merge
4
commits into
custom-cards:master
Choose a base branch
from
hjbotha:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a fanart_height configuration option which applies when image_style is fanart.
@hjbotha my apologies for the very late response. It looks like the code has changed significantly since you made this PR 5 years ago. If you still want to see this feature, I can try to add it on my own. |
Hey, unfortunately i cannot test the card right now because the trakt component seems to have issues that make it unable to setup. Looks fine though from the screenshot on Github, go for it. BestVom Handy gesendet.Am 01.02.2024 um 23:30 schrieb MKANET ***@***.***>:
@hjbotha @WongGendheng I am about make a very big update to upcoming-media-card.js. I fixed a few bugs. However, the most notable change I'm not sure is a good idea or not...
I changed the default to use transparency+mild backdrop-filter effect instead of the original dark fully-opaque effect. Currently, it can be disabled with disable_transparency: true in the card settings.
Can you guys please see if my changes are acceptable as the new default or I should only make transparency as optional?
https://github.com/mkanet/upcoming-media-card/blob/master/upcoming-media-card.js
If I don't hear back from you guys, I'll assume these changes are acceptable "as is".
Thanks in advance.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fanart_height option applies when image_style is fanart and adjusts the height of each entry on the cards. The start and mid points for the gradients are determined automatically based on the adjusted width of the fan art.
If you have multiple cards with different heights the gradients get messed up, but as this is an existing issue for other styles I thought it might be ok. I don't know enough about JS/Lovelace/CSS to fix that.