Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildout tests for gist / url loading #156

Merged
merged 2 commits into from
Jun 29, 2015
Merged

Buildout tests for gist / url loading #156

merged 2 commits into from
Jun 29, 2015

Conversation

alukach
Copy link
Member

@alukach alukach commented Jun 24, 2015

A series of tests to accompany #130.

Finally feeling strong about my JavaScript testing game 💪, I think this covers the features well.

Also, modified the format of the resultsPkg sent back from operations:

Old:

{
    add: [{
        name: "along_line.geojson",
        geometry: {"type":"Feature","geometry":{"type":"Point","coordinates":[-10.839132601858164,38.352329563649434]},"properties":{}}
    }]
}

New:

{
    add: [{
        name: "along_line.geojson",
        geojson: {"type":"Feature","geometry":{"type":"Point","coordinates":[-10.839132601858164,38.352329563649434]},"properties":{}}
    }]
}

It felt a bit confusing to use geometry as a key when the data has a geometry key within it.


expect(requests.length).to.equal(1);
expect(requests[0].url).to.equal('http://google.com');
// expect(callback.called).to.equal(true); // TODO: We should assert that the callback is called with proper results data. This seems to fail for some reason.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the only part of the tests that I couldn't get to operate properly. Still not sure what's up with it.

alukach added a commit that referenced this pull request Jun 29, 2015
Buildout tests for gist / url loading
@alukach alukach merged commit a1eb74c into master Jun 29, 2015
@alukach
Copy link
Member Author

alukach commented Jun 29, 2015

This one seems non-contentious, merging in.

@mapsam
Copy link
Member

mapsam commented Jul 1, 2015

👍

@mapsam mapsam deleted the testing/operations branch July 1, 2015 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants