This repository has been archived by the owner on Jan 27, 2022. It is now read-only.
fetch upstream #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes #3180 #3966 is implementing the same functionality (and more) but the author has lost interest and I don't have the knowledge to take over the unnest parts of his PR, I felt my solution to multiple joins is simple enough the other functionality could be rebased on top of it assuming a new owner takes it on.
The new compute beta makes use of xerrors which is causing regen to fail since we don't depend on this yet. This change will be blown away by regen, which is intended.
RowIterator can currently come from calling Read() on a Table, Read() on a Job, and Read() directly from a Query. The third invocation is used for fast path queries and doesn't return a query identifier suitable for gathering statistics. This PR exposes a SourceJob() method on RowIterator to address this issue. Users still get the benefits of optimized query execution, but can get the reference to a Job for looking up additional statistics should they need it. Fixes: #4745
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#675 Changes: feat(functions): add SecurityLevel option on HttpsTrigger PiperOrigin-RevId: 396889803 Source-Link: googleapis/googleapis@44c497f docs(bigquery/storage): Align session length with public documentation feat: Expose estimated bytes that a session will scan. Committer: @emkornfield PiperOrigin-RevId: 396849937 Source-Link: googleapis/googleapis@5661452 feat(talent): Added a new `KeywordMatchMode` field to support more keyword matching options feat: Added more `DiversificationLevel` configuration options PiperOrigin-RevId: 396667150 Source-Link: googleapis/googleapis@caad48d chore(accessapproval): remove nonexistent method from config PiperOrigin-RevId: 396610698 Source-Link: googleapis/googleapis@bdde047
Added a new feature to the generator to start generating modules for newly added clients. This can be done by adding the new -generate-module flag. The code generated in this PR has been made with these updated generator changes. Example command to generate a new module and client: go run cloud.google.com/go/internal/gapicgen/cmd/genbot -local -gocloud-dir /path/to/google-cloud-go -only-gapics -gapic=cloud.google.com/go/contactcenterinsights/apiv1 -generate-module This commit will be tagged: - networksecurity/v0.1.0 - accesscontextmanager/v0.1.0 - contactcenterinsights/v0.1.0 Changes: feat(internal/gapicgen): add ability to carve a module when generating feat(networksecurity): start generating clients feat(monitoring/metricsscope): start generating apiv1 feat(accesscontextmanager): start generating clients feat(contactcenterinsights): start generating clients feat(networkconnectivity): start generating apiv1 feat(resourcemanager): start generating apiv3
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#676 Changes: feat(recaptchaenterprise): add GetMetrics and MigrateKey methods to reCAPTCHA enterprise API PiperOrigin-RevId: 396937887 Source-Link: googleapis/googleapis@020672e
Previously the documentation said that omitempty omits "zero values" (linking to the spec), and then says structs aren't (but I didn't find that part clear the first 5 times I read it). I found this pretty unclear, especially since it's burying the fact that it differs from `encoding/json` in its special handling of `time.Time`. Hopefully being more explicit is clearer.
Skips test mentioned in #4772 and improves logging in the test.
Co-authored-by: Christopher Wilcox <[email protected]>
* feat(spanner/spannertest): Support generated columns * Add support for LOWER function * Remove checking of dependent columns and improve testing * docs: fix a couple of comments * Make CI happy with casing * Don't panic if columns are nil in generated columns using funcs * No longer returning code.InvalidArgument when calling db_eval.evalFunc but that seems consistent with the rest of the module, no tests failed so I assume its not behaviour relied upon, we could check for the error type instead * Add ErrorIs and make functions public to allow spannertest to use * fix: add errorIs to spannertest package * fix: remove unrelated changes * fix: remove specific error checking and return null from evaluations * fix: restore to original errors * Prettify comments * test: add error msg + delete test Co-authored-by: Knut Olav Løite <[email protected]>
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#677 Changes: feat(contactcenterinsights): filter is used to filter conversations used for issue model training feat: update_time is used to indicate when the phrase matcher was updated PiperOrigin-RevId: 397164390 Source-Link: googleapis/googleapis@2ec8242
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#680 Changes: chore(accesscontextmanager): Embed accesscontextmanager/type types into the accesscontextmanager/v1 client PiperOrigin-RevId: 397860208 Source-Link: googleapis/googleapis@835a0e0 chore(networksecurity): Configure Ruby GAPIC generator parameters for networksecurity v1beta1 and identitytoolkit v2 PiperOrigin-RevId: 397826566 Source-Link: googleapis/googleapis@6d969eb feat(speech): add output_config request field Committer: @cherba PiperOrigin-RevId: 397621106 Source-Link: googleapis/googleapis@1872f45 chore(bigquery/connection): update gapic-generator-csharp to 1.3.8 Committer: @virost PiperOrigin-RevId: 397402402 Source-Link: googleapis/googleapis@abed0ad chore(privatecatalog): enable python snippetgen for privatecatalog Committer: @busunkim96 PiperOrigin-RevId: 397369926 Source-Link: googleapis/googleapis@83728bb feat(bigquery/storage): add BigQuery Storage Write API v1 Committer: @yirutang PiperOrigin-RevId: 397350004 Source-Link: googleapis/googleapis@b4da4fd
Because of how the gax package is structured today it ends up pulling in proto and gRPC which can add a lot of extra deps to the tree if all you really need is this package. Fixes: #4783
attempt to fix #4741
…ature (#5059) As part of the changes for #5048 one callsite of getJobInternal was missed. Normally this would easily get identified due to the change in signature, but getJobInternal has a set of expected string arguments, followed by variadic string args. This got picked up by integration testing, but I failed to recall that presubmit doesn't run integration tests so it was caught after submit. Mostly this one's a cautionary tale for having a mix of mandatory and variadic functions that share the same type. Fixes: #5058
* test(storage): use current googler email in integration test * test(storage): use allAuthenticatedUsers
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#712 Changes: docs(talent): fix docstring formatting Committer: @parthea PiperOrigin-RevId: 406427586 Source-Link: googleapis/googleapis@c2b080f chore(cloudbuild/apiv1): Update cloudbuild BUILD.bazel package name to google-cloud-build chore(python): Update cloudbuild namespace to google.cloud.devtools PiperOrigin-RevId: 406424368 Source-Link: googleapis/googleapis@a83e6f2 chore(accessapproval): Update accessapproval BUILD.bazel package name to google-cloud-access-approval PiperOrigin-RevId: 406423937 Source-Link: googleapis/googleapis@3045b0c
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#713 Changes: feat(recaptchaenterprise): add reCAPTCHA Enterprise account defender API methods This cl adds the following API methods to support the Preview release of reCAPTCHA Enterprise account defender: ListRelatedAccountGroups, ListRelatedAccountGroupMemberships, and SearchRelatedAccountGroupMemberships. Additionally it modifies the existing createAssessment API method to add a new hashed_account_id parameter along with AccountDefenderAssessment return value. PiperOrigin-RevId: 407130991 Source-Link: googleapis/googleapis@d58e602 docs(recommender): fix docstring formatting Committer: @parthea PiperOrigin-RevId: 406921699 Source-Link: googleapis/googleapis@6d008d2 feat(aiplatform): Adds support for `google.protobuf.Value` pipeline parameters in the `parameter_values` field PiperOrigin-RevId: 406492721 Source-Link: googleapis/googleapis@7a3953f
* feat(spanner/spansql): support CAST and SAFE_CAST Adds support for the CAST and SAFE_CAST functions. This change also includes a small refactor of the function evaluation to allow the function evaluation to receive both parsing errors and type information for the arguments. This makes it easier to implement the SAFE versions of the functions. * fix: only ignore conversion errors in SAFE_CAST * fix: outdent else statement Co-authored-by: rahul2393 <[email protected]> Co-authored-by: Hengfeng Li <[email protected]>
* chore(): add encocom as codeowner * Update CODEOWNERS
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#715 Changes: feat(dialogflow/cx): added support for comparing between versions docs: clarified security settings API reference PiperOrigin-RevId: 407624272 Source-Link: googleapis/googleapis@eb773f2 docs(channel): clarified usage of entitlement parameters PiperOrigin-RevId: 407463572 Source-Link: googleapis/googleapis@e4c5b78 feat(osconfig): OSConfig: add OS policy assignment rpcs Committer: @adjackura PiperOrigin-RevId: 407422484 Source-Link: googleapis/googleapis@c11bc3e fix(security/privateca): repair service config to enable mixins PiperOrigin-RevId: 407356040 Source-Link: googleapis/googleapis@171e2c7
Test had an expectation on BI Engine statistics presence, however test environments don't have BI resources provisioned. Relax the test. Fixes: #5083
… call options (#5078) BREAKING CHANGE: changes function signatures to add variadic call options This plumbs the ability to pass gax.CallOption opts to the underlying client underpinning the ManagedStream. It also adds a WithAppendRowsCallOption option to the constructor, as well as adding direct option passing for operations like Finalize() and FlushRows(). Towards: #4366
* Filters presubmit tests based on changed directories * Adds emulator tests to be run when all module tests run, such as during regular nightly jobs
…o CBT (#5072) Co-authored-by: Christopher Wilcox <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.