Call normalize after load document. #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes a doc is just broken and need fix. current load document code does not call normalization after load doc. This PR add a force normalization after code load, then call the onChange to prevent from some crash due to invalid doc structure.
But, I am not sure whether this is a common good implement since it fix the doc structure without warning or logging, client code has no chance to involve this. on the other hand, without this change, it probably just crash due to the onChange call finally do some batch before render work in Slate.
So, this is just the my current workaround for broken doc, maybe not a perfect PR for general cases.