fix(schema-compiler): Allow no-cache queries to use pre-aggregations#10440
Merged
fix(schema-compiler): Allow no-cache queries to use pre-aggregations#10440
Conversation
no-cache mode now only skips the result cache (via forceNoCache in QueryCache) but still routes queries through pre-aggregation tables when available, avoiding expensive source database queries. We initially discussed this exact behavior, but we skipped it. Skipping pre-aggregations doesn't make sense, since the cache parameter controls the in-memory cache.
github-actions
bot
added
the
javascript
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #10440 +/- ##
===========================================
- Coverage 83.37% 57.53% -25.85%
===========================================
Files 250 222 -28
Lines 74886 17370 -57516
Branches 0 3558 +3558
===========================================
- Hits 62434 9993 -52441
+ Misses 12452 6841 -5611
- Partials 0 536 +536
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ovr
force-pushed
the
fix/no-cache-must-hit-pre-agg
branch
from
169f924 to
cbe6876
Compare
ovr
force-pushed
the
fix/no-cache-must-hit-pre-agg
branch
from
cbe6876 to
e526eaf
Compare
waralexrom
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no-cache mode now only skips the result cache (via forceNoCache in QueryCache) but still routes queries through pre-aggregation tables when available, avoiding expensive source database queries.
We initially discussed this exact behavior, but we skipped it. Skipping pre-aggregations doesn't make sense, since the cache parameter controls the in-memory cache.