fix(schema-compiler): Added templates.expressions.timestamp_literal for MySQL and DuckDB#10426
Open
pjleiwa6g wants to merge 2 commits intocube-js:masterfrom
Open
fix(schema-compiler): Added templates.expressions.timestamp_literal for MySQL and DuckDB#10426pjleiwa6g wants to merge 2 commits intocube-js:masterfrom
pjleiwa6g wants to merge 2 commits intocube-js:masterfrom
Conversation
… have timestamp between quotes and in thhe right format.
github-actions
bot
added
javascript
pjleiwa6g
changed the title
pjleiwa6g
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using TO_TIMESTAMP() in WHERE clause + aggregate function rewrite goes wrong -> timestamp value is not placed between quotes. Seen for MySQL and DuckDB as a source database.
Issue Reference this PR resolves
Fixes: Issue 10421
See issue 10421 to reproduce.
Description of Changes
Added to MysqlQuery.ts
templates.expressions.timestamp_literal = 'TIMESTAMP(\'{{ value | replace("T", " ") | replace("Z", "") }}\')';Added to DuckDBQuery.ts
templates.expressions.timestamp_literal = '\'{{ value }}\'';Overwrites setting in BaseQuery.js. Puts value in right format and places it between quotes.
Check List