Skip to content

Fixes syntax error in python script and updates readme with correct i… #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simonengstrm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes syntax error in python script and updates readme with correct i… #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,12 @@ These variables should all be applied to the frontend.

These variables should all be applied to the backend.
- `GAMMA_SECRET`: Default `secret`.
- `GAMMA_CLIENT_ID`, `GAMMA_CLIENT_SECRET`: Id and secret of the client from Gamma. Default is `id`/`secret`.
- `GAMMA_CLIENT_ID`: Id of the client from Gamma. Default is `id`.
- `GAMMA_AUTHORIZATION_URI`:
- Should be the full URL, probably: `https://songbook.chalmers.it/api/oauth/authorize`.
- Should be the full URL, probably: `https://gamma.chalmers.it/api/oauth/authorize`.
- Default: `http://localhost:8081/api/oauth/authorize`.
- `GAMMA_REDIRECT_URI`:
- Should as well be the full URL, probably: `https://gamma.chalmers.it/api/auth/account/callback`.
- Should as well be the full URL, probably: `https://songbook.chalmers.it/auth/account/callback`.
- Default `http://localhost:3001/auth/account/callback`.
- `GAMMA_ME_URI`:
- Yep, full URL, probably: `https://gamma.chalmers.it/api/users/me`
Expand Down
4 changes: 2 additions & 2 deletions backend/start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
wait_for_postgres() (
wait_for_postgres() {
first_iteration=true
while ! pg_isready -h "$SONGBOOK_POSTGRES_HOST" -p "$SONGBOOK_POSTGRES_PORT" -q; do
if [ -n "$first_iteration" ]; then
Expand All @@ -11,7 +11,7 @@ wait_for_postgres() (
sleep 1
done
if [ -z "$first_iteration" ]; then echo; fi
)
}

wait_for_postgres
python -u src/app.py