feat(vips): allow the watermark thumbnail to also upscale the image #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The SizeBoth works when the aspect ratio is specified, and tests pass on my local. One thing I realised is that we can upscale the image to be bigger than the source, but then the x, y get a bit lost for the way it was built. |
|
close per #435 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refers to: #397
The current behaviour of the watermark filter does not allow the watermark image to upscale. So, when the percentage is set, it does not necessarily refer to the base image because it has a limit (the size of itself). Allowing it to upscale makes more sense for this case. If we want to have a limit, I believe it should be set over the base image and not on the watermark.