-
Notifications
You must be signed in to change notification settings - Fork 5
2.0 snapshot #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.0-SNAPSHOT
Are you sure you want to change the base?
2.0 snapshot #34
Conversation
…shing_maven.html describes the favored way of publishing maven artifacts (https://docs.gradle.org/4.8/release-notes.html#overwriting-gradle%E2%80%99s-built-in-tasks)
…ionality changed: example 1-helloworld was split up, because gradle.document task cannot be overwritten. All tasks defined in LatexExtension do not overwrite anymore. Therefore different gradle-latex projects with the same tex-document name may behave differently. Publishing was changed. ToDo: testjar upload not implemented.
…d 1-otherpdfname.
…ravis-ci standard).
… Now, again doing it with on-board means.
… this. Try this again.
|
| jdk: oraclejdk8 | ||
| # test with java 9 support | ||
| jdk: | ||
| - openjdk11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JDK8 should still be tested, many still use it AFAIK. So I think it should be part of the list
.travis.yml
Outdated
| before_install: | ||
| - wget https://services.gradle.org/distributions/gradle-6.2.1-bin.zip | ||
| - unzip -qq gradle-6.2.1-bin.zip | ||
| - export GRADLE_HOME=$PWD/gradle-6.2.1 | ||
| - export PATH=$GRADLE_HOME/bin:$PATH | ||
| - gradle -v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember why installing Gradle wasn't necessary before (I'm mostly using GitLab since then), was it already part of the CI environment? If this is necessary, then using the wrapper might be better, it's why it's there. So IMO let's not gitignore it, add it with this version, and call gradlew in the CI scripts below. Any reason against it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the time of implementing Gradle 6 was not shipped with Travis CI. I will check if it is now.
| } | ||
|
|
||
| developers { | ||
| developer { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please feel free to add yourself to this list :)
| @@ -0,0 +1,4 @@ | |||
| wrapper { | |||
| gradleVersion = '6.1-rc-1' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this mechanism something new? Is this file auto-loaded? I though gradle generated a properties file in a subfolder for this information, and that's now gitignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the time of implementing Gradle 6 was not shipped with Travis CI. I will check if it is now.
| include '3-withdependent' | ||
| include '4-withauxdir' | ||
| include '5-withcmdargs' | ||
| include '6-withsvgs' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new example 0 should also be included here.
The build did not pass and does it again. Small change. Do not bother the .gitignore commit.