Skip to content

Conversation

@Boltzmann
Copy link

The build did not pass and does it again. Small change. Do not bother the .gitignore commit.

…ionality changed: example 1-helloworld was split up, because gradle.document task cannot be overwritten. All tasks defined in LatexExtension do not overwrite anymore. Therefore different gradle-latex projects with the same tex-document name may behave differently. Publishing was changed. ToDo: testjar upload not implemented.
@Boltzmann
Copy link
Author

  • The Travis-CI build is green with Gradle 6 and Java 11.
  • Examples compile. I used this fork to work with the plugin.
  • Added new examples.
  • Testing the availability of tasks and their results of Csabas 2.0-SNAPSHOT branch would have been nice to know that the functionality in the Boltzmann fork is still there. However, I only did the checks by hand. On my computer sources and javadocs are published to the local maven.
  • I do not know how to test the official Maven repo publish functionality without really publishing it there. So did only test local Maven Repo checks.

@Boltzmann Boltzmann closed this Mar 13, 2020
@Boltzmann Boltzmann deleted the 2.0-SNAPSHOT branch March 13, 2020 20:24
@Boltzmann Boltzmann restored the 2.0-SNAPSHOT branch March 13, 2020 20:25
@Boltzmann Boltzmann reopened this Mar 13, 2020
jdk: oraclejdk8
# test with java 9 support
jdk:
- openjdk11
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JDK8 should still be tested, many still use it AFAIK. So I think it should be part of the list

.travis.yml Outdated
Comment on lines 10 to 15
before_install:
- wget https://services.gradle.org/distributions/gradle-6.2.1-bin.zip
- unzip -qq gradle-6.2.1-bin.zip
- export GRADLE_HOME=$PWD/gradle-6.2.1
- export PATH=$GRADLE_HOME/bin:$PATH
- gradle -v
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why installing Gradle wasn't necessary before (I'm mostly using GitLab since then), was it already part of the CI environment? If this is necessary, then using the wrapper might be better, it's why it's there. So IMO let's not gitignore it, add it with this version, and call gradlew in the CI scripts below. Any reason against it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the time of implementing Gradle 6 was not shipped with Travis CI. I will check if it is now.

}

developers {
developer {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please feel free to add yourself to this list :)

@@ -0,0 +1,4 @@
wrapper {
gradleVersion = '6.1-rc-1'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this mechanism something new? Is this file auto-loaded? I though gradle generated a properties file in a subfolder for this information, and that's now gitignored.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the time of implementing Gradle 6 was not shipped with Travis CI. I will check if it is now.

include '3-withdependent'
include '4-withauxdir'
include '5-withcmdargs'
include '6-withsvgs'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new example 0 should also be included here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants