fix: support pygls v2 LanguageServer import#25
Merged
Conversation
- Update pygls dependency to >=2.0.0 - Update imports from pygls.server to pygls.lsp.server - Update method calls to use v2 params-based API: - show_message() -> window_show_message(ShowMessageParams) - show_message_log() -> window_log_message(LogMessageParams) - publish_diagnostics() -> text_document_publish_diagnostics(PublishDiagnosticsParams) - Update tests for new API Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
9c33bad to
97eb4ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context / Bug
slither-lspimportsLanguageServerfrompygls.server.In
pygls>=2.0,LanguageServerwas moved topygls.lsp.server, so the import fails and the LSP crashes on startup with:ImportError: cannot import name 'LanguageServer' from 'pygls.server'Impact
Any environment that resolves
pygls>=2(e.g., uv tool installs) fails to startslither-lsp, causing the VSCode extension to repeatedly restart the server and never initialize.Fix
Add a backward‑compatible import shim that tries the old path first and falls back to the new path: