feat: add environment variable configuration via .env files#104
Open
NightTrek wants to merge 1 commit intocrystaldba:mainfrom
Open
feat: add environment variable configuration via .env files#104NightTrek wants to merge 1 commit intocrystaldba:mainfrom
NightTrek wants to merge 1 commit intocrystaldba:mainfrom
Conversation
- Add python-dotenv dependency for loading environment variables from .env files - Create comprehensive .env.example template with all supported configuration options - Implement .env file loading in server.py with proper precedence handling: * Command-line arguments (highest priority) * Environment variables * Values from .env file * Default values (lowest priority) - Support both DATABASE_URI and individual connection parameters (DB_HOST, DB_PORT, etc.) - Add environment configuration documentation to README.md - Maintain backward compatibility with existing configuration methods This enhancement improves security by keeping sensitive credentials out of command-line arguments and version control, while providing a more convenient configuration workflow for development and deployment scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enhancement improves security by keeping sensitive credentials out of command-line arguments and version control, while providing a more convenient configuration workflow for development and deployment scenarios.