Improve Process::Status#to_s for abnormal exits on Windows
#15283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:feature
platform:windows
straight-shoota
force-pushed
the
feat/process_status-stringify-windows-abnormal
branch
from
3b67473 to
f36709e
Compare
straight-shoota
force-pushed
the
feat/process_status-stringify-windows-abnormal
branch
from
f36709e to
f3d9f77
Compare
ysbaddaden
approved these changes
Dec 17, 2024
oprypin
reviewed
Dec 17, 2024
straight-shoota
deleted the
feat/process_status-stringify-windows-abnormal
branch
straight-shoota
added a commit
that referenced
this pull request
Dec 20, 2024
Status numbers on Windows are usually represented in hexadecimal notation. This applies that for all large exit status values (above `UInt16::MAX`, inspired from https://cs.opensource.google/go/go/+/refs/tags/go1.23.4:src/os/exec_posix.go;l=117-121). This again improves usability because it's easier to interpret unknown status values and compare them with listings sharing the typical number format. In #15283 we already changed `Status#to_s` to print the name of known values. But not all status codes are named.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abnormal exit statuses on Windows are indicated by specific status values which correlate to
LibCconstants.This patch changes
Status#to_s(and#inspect) to return the name of the constant if available. This improves usability because it's easier to interpret the status.Follow-up on #15267