Add Colorize::Object#ansi_escape
#15113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reading the current CI failures are pointing to |
|
Seems to have been an environment issue, suddenly it's working fine again... |
straight-shoota
approved these changes
Oct 21, 2024
straight-shoota
approved these changes
Dec 16, 2024
|
I renamed the method to |
straight-shoota
changed the title
Colorize::Object#printColorize::Object#ansi_escape
ysbaddaden
approved these changes
Dec 16, 2024
|
Thank you @straight-shoota, it seems I've been missing notifications again. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15079.
I am cautious of the spec test for(resolved now).bright.printas it returned different results when testing.