-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
union
, intersection
and overlaps?
for Range
s
#15106
Open
CTC97
wants to merge
20
commits into
crystal-lang:master
Choose a base branch
from
CTC97:ranges-union_intersection_overlaps
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
c704bc2
ranges - union; intersection; overlaps?
CTC97 22688e9
crystal tool format
CTC97 1775ddb
nit :broom:
CTC97 0493274
nil returns, specs
CTC97 8bda941
additional tests + adjacency ambiguity
CTC97 47b0627
code cleanup
CTC97 9e236be
nit
CTC97 40791b0
Merge branch 'master' into ranges-union_intersection_overlaps
CTC97 75f9561
cleanup :broom:
CTC97 81b7e8a
Merge branch 'master' into ranges-union_intersection_overlaps
CTC97 277e6fd
Merge branch 'master' into ranges-union_intersection_overlaps
CTC97 5bb3857
adjacency check for unions
CTC97 3f64dca
Merge branch 'master' into ranges-union_intersection_overlaps
CTC97 2a3801a
exclusive range checks + refined range definitions
CTC97 32d3843
Merge branch 'master' into ranges-union_intersection_overlaps
CTC97 9f0e60c
format check fix :hammer:
CTC97 771e3e4
nit.
CTC97 67ebd95
addressed empty ranges + updated spec
d4e35c1
format + logic fix
e4221d1
docs update
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we can get away with hardcoding a
Range(Int32, Int32)
specifically. My own use case for this functionality is actuallyRange(Time, Time)
, so I'd get compile-time errors with this return value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, and thank you for the quick review!
I'll get on these changes asap! ✌️⭐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we revert from
0..0
to the originally suggestednil
? I think it makes sense, but open to other options.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using any of the four endpoints here instead of
0
should probably work tooThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me nil seems like a more logical return value than using any of the existing endpoints which might be confusing.
Totally open to your reasoning though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think the intersection of a list returning a nil vs an empty list: which feels more logical? Which is less of a burden?
Returning
nil
means that the methods always return a nilable type (Range(B, E) | Nil
) and we must always check if the value is nil or not before we can do anything.Returning an empty range means we always return a Range(B, E) that would act as a NOOP object, and if we need to know if the range is empty, we can call
Range#empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW:
0..0
wasn't an empty range, it's a range with a single value (starts at 0 and terminates at 0 inclusive):