Decouple warning detection from program instances #12293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all the warning settings and detected warnings into a new
Crystal::WarningCollection
object. A newCrystal::Compiler
orCrystal::Program
comes with its own warning collection, but a collection may also be explicitly shared between them, whichCompiler#new_program
does. The sharing is needed because warnings from either component could trigger--error-on-warnings
.If we want to extend this to syntax warnings (see for example #12197 (comment) and #8373 (comment)), the treatment is also similar:
This gives the parser access to the compiler's warning settings, whereas a stand-alone parser is also able to maintain its own list of warnings without going through a program.
A
Crystal::MacroInterpreter
is never created alone, so it merely reuses its parent program's warning collection.