Fix bug where private/protected methods were hidden in a class nested…

… in a :showdoc: class
crystal-lang · Dec 19, 2024 · cd722b6 · cd722b6
1 parent fb52146
commit cd722b6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/src/compiler/crystal/tools/doc/generator.cr b/src/compiler/crystal/tools/doc/generator.cr
@@ -236,16 +236,6 @@ class Crystal::Doc::Generator
     false
   end
 
-  def showdoc?(obj)
-    return false if !@program.wants_doc?
-
-    if showdoc?(obj.doc.try &.strip)
-      return true
-    end
-
-    false
-  end
-
   def crystal_builtin?(type)
     return false unless project_info.crystal_stdlib?
     # TODO: Enabling this allows links to `NoReturn` to work, but has two `NoReturn`s show up in the sidebar

diff --git a/src/compiler/crystal/tools/doc/type.cr b/src/compiler/crystal/tools/doc/type.cr
@@ -267,7 +267,7 @@ class Crystal::Doc::Type
   end
 
   private def showdoc?(adef)
-    @generator.showdoc?(adef.doc.try &.strip) || @generator.showdoc?(self)
+    @generator.showdoc?(adef.doc.try &.strip) || @generator.showdoc?(@type)
   end
 
   private def sort_order(item)