Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs #529

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Nov 18, 2023

This is my proposal for site navigation.
Breadcrumbs indicate the current location in the navigation tree. They also provide navigation options to traverse up, and down.

Team page with bread crumbs:
image

Community page with bread crumbs and navigation links to other pages in that section:
image

Copy link

netlify bot commented Nov 18, 2023

Deploy Preview for crystal-website ready!

Name Link
🔨 Latest commit c9cb3ac
🔍 Latest deploy log https://app.netlify.com/sites/crystal-website/deploys/65a542deb68e3a000843d7be
😎 Deploy Preview https://deploy-preview-529--crystal-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@straight-shoota straight-shoota force-pushed the feat/breadcrumbs branch 3 times, most recently from 358c672 to 97f8e2e Compare November 22, 2023 20:52
@straight-shoota straight-shoota marked this pull request as ready for review November 22, 2023 20:52
This was referenced Nov 23, 2023
@straight-shoota straight-shoota force-pushed the feat/breadcrumbs branch 2 times, most recently from 0bcf97b to c512d94 Compare November 24, 2023 11:04
@beta-ziliani
Copy link
Member

I'm not convinced for two reasons: it takes a significant portion of the vertical space, and I don't think the header adds much (and is kinda confusing to have Home / Community in Sponsors, when you conceptually have also Home / Sponsors). Let's discuss this with the design team.

@straight-shoota
Copy link
Member Author

straight-shoota commented Nov 24, 2023

it takes a significant portion of the vertical space

I beg to differ on that statement. The height of the bread crumb line alone (which is the only thing visible on most pages) is anywhere between 25px and 35px depending on the viewport size. That's a third of the top nav bar and IMO pretty negligible. And I think there could even be some slack to reduce the whitespace above the page title on smaller viewports if we need to maximum vertical content space.

On section main pages there's an additional line with links to sub pages. That adds additional ~10px. But the thing is: We need to enable this navigation flow in some way. So if not so, then it needs some other element. I think this solution uses very little extra space, is quite elegantly usable on any device.

Either way, the vertical distance from the top of the viewport to the start of the first content item is reduced significantly from the current version of the website. And I don't think that vertical space is wasted too much on that. It can easily be reduced and still be aesthetically pleasing while being more functional, but it's not excessively disturbing. So in any case we're already improving a lot on vertical distance from the current baseline.

If we want to further reduce vertical space we yould perhaps consider an integration between bread crumbs and the top nav bar. Rough idea could look like this:
grafik
This would be more akin to the top nav bar in the current version of the website. For comparison:
grafik

More on this in #548

@straight-shoota straight-shoota mentioned this pull request Jan 22, 2024
@straight-shoota
Copy link
Member Author

Superseded by #548.

@straight-shoota straight-shoota deleted the feat/breadcrumbs branch January 29, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants