Allow identifiers with trailing ? or ! in more places #88
Conversation
nobodywasishere
force-pushed
the
nobody/ident-trailing-qe
branch
from
08ec53f to
a9621dd
Compare
| not equals call without spaces | ||
| ============================== | ||
|
|
||
| # should be `(foo) != (true)` but is `(foo!) = (true)` |
There was a problem hiding this comment.
Will need some scanner stuff to get this working
|
While this syntax wasn't intentional (see crystal-lang/crystal#10917), it may be used by some programs so we should support it. |
There was a problem hiding this comment.
I'm hesitant about this change, considering:
- Hopefully Check that def, macro, and block parameters don't end with
?or!crystal-lang/crystal#12197 is moving forward to add a warning - A lot of rules need to be updated, so it would be a bit of trouble to roll this back if the syntax is removed
- tree-sitter's error recovery already deals with trailing
?and!pretty well
| [ | ||
| $.identifier_method_call, | ||
| $.identifier, | ||
| ], |
|
That's valid. I'll leave this as a draft for now in case that doesn't go forward and the current behavior stays as-is |
| @@ -1227,7 +1243,19 @@ module.exports = grammar({ | |||
| ), | |||
|
|
|||
| c_struct_fields: $ => { | |||
| const names = seq($.identifier, repeat(seq(',', $.identifier))) | |||
| const names = seq( | |||
There was a problem hiding this comment.
Outside of params, this and type declaration I don't expect to change. What are your thoughts on just adding these?
There was a problem hiding this comment.
I don't think I understand, which ones specifically?
There was a problem hiding this comment.
type declaration names and c struct / union fields
No description provided.