Improve implicit object call support #54
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
keidax
force-pushed
the
keidax/implicit-index
branch
from
6d5e665 to
bd89120
Compare
|
I'm fine aliasing implicit_obj_* to just calls / etc, as long as it doesn't break impl object in case statements |
devnote-dev
requested changes
Dec 19, 2024
We can reuse tokens for `$.instance_var` and others, instead of creating separate token versions with the leading `.` The fields for `implicit_object_call` tree nodes now match the fields for `call` nodes More implicit call syntax is supported
|
There's a different direction I want to take this PR, but I'd like to get some clarity on crystal-lang/crystal#15303 before moving forward. Any changes to the block precedence rules could cause conflicts with this change. |
keidax
force-pushed
the
keidax/implicit-index
branch
from
bd89120 to
79d349f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more supported syntax 🤝 smaller parser size