feat: Strings Exporter Settings methods #304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelvson
changed the title
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
==========================================
+ Coverage 92.08% 92.17% +0.09%
==========================================
Files 34 34
Lines 1376 1391 +15
Branches 117 117
==========================================
+ Hits 1267 1282 +15
Misses 75 75
Partials 34 34
|
| @@ -548,6 +611,24 @@ export namespace ProjectsGroupsModel { | |||
| updatedAt: string; | |||
| } | |||
|
|
|||
| export interface AddProjectStringsExporterSettings { | |||
| format: string; | |||
| settings: Settings; | |||
There was a problem hiding this comment.
This Settings type is not suitable here. The new type should be created instead.
https://developer.crowdin.com/api/v2/#operation/api.projects.strings-exporter-settings.post
| @@ -579,4 +660,8 @@ export namespace ProjectsGroupsModel { | |||
| importNotes?: boolean; | |||
| importHiddenSlides?: boolean; | |||
| } | |||
|
|
|||
| export interface StringsExporterSettings extends CommonFileFormatSettings { | |||
There was a problem hiding this comment.
This is also not related to the CommonFileFormatSettings and shouldn't extend it
There was a problem hiding this comment.
This file shouldn't be here
andrii-bodnar
added
the
hacktoberfest
|
@nelvson do you need any assistance with resolving the discussions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
listProjectStringsExporterSettings()addProjectStringsExporterSettings()getProjectStringsExporterSettings()deleteProjectStringsExporterSettings()editProjectStringsExporterSettings()Related Issue