feat(rds): add standard connection secret keys for crossplane-runtime compatibility #1930
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keralin
requested review from
erhancagirici,
jastang,
sergenyalcin,
turkenf and
ulucinar
as code owners
Keralin
force-pushed
the
fix/rds-cluster-standard-connection-keys
branch
2 times, most recently
from
9bbfd3a to
a147c9b
Compare
… compatibility Add 'username' and 'password' keys to aws_rds_cluster connection secrets to enable compatibility with provider-sql and other consumers that expect standard crossplane-runtime connection secret keys. Existing keys (master_username, master_password) are preserved for backwards compatibility. Fixes: crossplane-contrib#1189 Signed-off-by: Francisco Barón <[email protected]>
Keralin
force-pushed
the
fix/rds-cluster-standard-connection-keys
branch
from
a147c9b to
d822e4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
usernameandpasswordkeys toaws_rds_clusterconnection secrets to enable compatibility withprovider-sqland other consumers that expect standard crossplane-runtime connection secret keys.Changes:
username(alias ofmaster_username) andpassword(frommaster_password) to connection secretsExisting keys (
master_username) are preserved for backwards compatibility.Connection Secret Output (after this fix)
Fixes #1189
Related issues: