allow provider listener ports to be configurable #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ravilr <[email protected]>
ravilr
requested review from
ulucinar,
sergenyalcin,
turkenf and
mbbush
as code owners
|
I'm marking this PR as "blocked" while we wait for upstream resolution of crossplane/crossplane#5540 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Part of crossplane/crossplane#5520
As outlined in the above issue, when running Crossplane in certain environments (like EKS using Calico CNI/Cilium in overlay network), where the control plane resides outside the workload network it is necessary to run webhooks in the host network. This calls for the need to make the listening ports(webhook and metrics) of provider controllers configurable to avoid conflicts.
I have:
make reviewableto ensure this PR is ready for review.[ ] Addedbackport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
DeploymentRuntimeConfig, and verified that a provider launched with these new flags with custom ports and correspondingDeploymentRuntimeConfig, had conversion webhook communications working without errors.