Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow provider listener ports to be configurable #1524

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ravilr
Copy link
Contributor

@ravilr ravilr commented Oct 14, 2024

Description of your changes

Part of crossplane/crossplane#5520

As outlined in the above issue, when running Crossplane in certain environments (like EKS using Calico CNI/Cilium in overlay network), where the control plane resides outside the workload network it is necessary to run webhooks in the host network. This calls for the need to make the listening ports(webhook and metrics) of provider controllers configurable to avoid conflicts.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • [ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

  • Deployed these changes along with the changes from feat/configurable ports crossplane/crossplane#5540, which allows customizing ports in DeploymentRuntimeConfig, and verified that a provider launched with these new flags with custom ports and corresponding DeploymentRuntimeConfig, had conversion webhook communications working without errors.

@jeanduplessis
Copy link
Collaborator

I'm marking this PR as "blocked" while we wait for upstream resolution of crossplane/crossplane#5540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants