Add options for skipping default tags #1474
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The PR introduces the argument
--skip-default-tags
which makes the provider skip setting the default tags:This is useful for "S3-compatible" services such as Scality Ring which implements all the required API for Crossplane except for tags. Currently the provider fails to create a bucket in Scality Ring since the tag API returns
501 NotImplemented
.Unfortunately this introduces changes to a lot of generated files since
hack/main.go.tmpl
is modified but the change is small. Unsure if there is a better way to solve this.Fixes #1141
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
This has been tested against localstack and works as previously without
--skip-default-tags
, when it's set it correctly skips setting the default crossplane tags for S3 buckets.We are running this change in production for a week now and it's working fine with the option
--skip-default-tags
added to theDeploymentRuntimeConfig
against Scality Ring which does not support tags.