Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for skipping default tags #1474

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikael-lindstrom
Copy link

Description of your changes

The PR introduces the argument --skip-default-tags which makes the provider skip setting the default tags:

  • crossplane-kind
  • crossplane-name
  • crossplane-providerconfig

This is useful for "S3-compatible" services such as Scality Ring which implements all the required API for Crossplane except for tags. Currently the provider fails to create a bucket in Scality Ring since the tag API returns 501 NotImplemented.

Unfortunately this introduces changes to a lot of generated files since hack/main.go.tmpl is modified but the change is small. Unsure if there is a better way to solve this.

Fixes #1141

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

This has been tested against localstack and works as previously without --skip-default-tags, when it's set it correctly skips setting the default crossplane tags for S3 buckets.

We are running this change in production for a week now and it's working fine with the option --skip-default-tags added to the DeploymentRuntimeConfig against Scality Ring which does not support tags.

Signed-off-by: Mikael Lindström <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable default tags
1 participant