Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tf resource to aws sdk group overrides #1200

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mbbush
Copy link
Collaborator

@mbbush mbbush commented Mar 9, 2024

Description of your changes

I wrote a pair of scripts to

  1. Extract two lists of all the framework and sdk resources from the source code of terraform-provider-aws (shell/sed)
  2. Use the generated lists to build the GroupMap (python)

My motivation was while working on support for some new MSK resources, they ended up in api group msk instead of kakfa like the other msk resources, because they weren't on the GroupMap list.

While working on getting the code to fully generate the GroupMap, I discovered what looked like several mistakes in the behavior of the previous GroupMap. I added conditionals to preserve the existing behavior, because doing otherwise would have resulted in changing the kind or api group of the affected resources.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

It produces zero diff to the generated code.

Copy link

This provider repo does not have enough maintainers to address every pull request. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label Oct 16, 2024
Copy link

This pull request is being closed since there has been no activity for 14 days since marking it as stale. If you're still working on this, feel free to reopen the PR or create a new one!

@github-actions github-actions bot closed this Oct 30, 2024
@erhancagirici erhancagirici reopened this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants