-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] remove sensitive data from MR and resolve references just before use to not leak secrets data in to MR after resolved. #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i have some failing tests left that i have to fix. and some todos to remove |
Signed-off-by: Christopher Haar <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Christopher Haar <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: rladdukodiraghav <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: rladdukodiraghav <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: rladdukodiraghav <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: ravilr <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: ravilr <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: ravilr <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
* Add `ObservedObjectCollection` API type Objects in the collection are defined by: * GVK * optional namespace * label selector The objects are fetched using the specified provider config and for the matched objects the provider creates counterpart observe-only objects in the local cluster. The created objects are owned by the collection resource and reconciled as usual by the provider. They are labeled with a common label, so that they can be fetched easily. The label is discoverable by reading `.status.membershipLabel` field of `ObservedObjectCollection`. Signed-off-by: Predrag Knezevic <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
See crossplane-contrib#233 Signed-off-by: Jack Jackson <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Co-authored-by: Jared Watts <[email protected]> Signed-off-by: Jack Jackson <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Fixes crossplane-contrib#138 Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: Hasan Turken <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
Signed-off-by: ezgidemirel <[email protected]> Signed-off-by: Alexander Brandstedt <[email protected]>
observer loop. This to stop secrets payload from ending in the MR and instead resolve one moretime for the secret just before use in Create/Update/Delete funcs Signed-off-by: Alexander Brandstedt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One implementation to fix #223 to not render sensitive data in to the MR from a secret rendered
Description of your changes
Fixes #
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested