Conversation
bobh66
requested review from
jbw976
and removed request for
negz,
sergenyalcin and
turkenf
Signed-off-by: Bob Haddleton <[email protected]>
Contributor
Author
|
@jbw976 should be squeaky clean now. Sorry about that. |
Member
|
Also note, this was split out from #165. @phisco @stevendborrelli please confirm you are still interested in being a maintainer on this function 🙇♂️ |
jbw976
approved these changes
Jan 6, 2026
Member
jbw976
left a comment
jbw976
left a comment
There was a problem hiding this comment.
This looks good to me, following up to get confirmation from @phisco and @stevendborrelli since the original PR for this #165 was awhile ago.
Member
|
Yes, I can be a code owner. |
phisco
approved these changes
Jan 6, 2026
Collaborator
phisco
left a comment
phisco
left a comment
There was a problem hiding this comment.
Sounds good to me, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add @stevendborrelli and @phisco