fix: release RefEntry in SkipList when dropping it #1217
+20
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a memory leak problem when using the SkipMap. Please take a look if this is the root cause.
This probably relates to #1178
The comment of
RefEntrysays:But when
RefEntryis overwritten byclone_from, there is nodecrementorrelease.I can reproduce a memory leak in the test
stress_skipmap_range_iterin tikv/tikv#19284