Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return elements for ContentState.loading to prevent blinking #501

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

mltbnz
Copy link
Member

@mltbnz mltbnz commented Mar 1, 2024

📲 What

  • return elements on ContentState also for loading case

🤔 Why

The chat view was blinking for a short while when loading items and showing the emptystate.

@mltbnz mltbnz added the bug label Mar 1, 2024
@mltbnz mltbnz self-assigned this Mar 1, 2024
@mltbnz mltbnz requested a review from a team as a code owner March 1, 2024 13:35
@mltbnz mltbnz changed the title Chat loading is not empty Return elements for ContentState.loading to prevent blinking Mar 1, 2024
@mltbnz mltbnz merged commit 1b8b6f0 into main Mar 5, 2024
1 check passed
@mltbnz mltbnz deleted the chat-loading-isNotEmpty branch March 5, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant