Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job output transform #548

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Job output transform #548

wants to merge 29 commits into from

Conversation

OlivGruwe
Copy link

@OlivGruwe OlivGruwe commented Aug 8, 2023 •
edited by fmigneault
Loading

fixes #18
fixes #100

Pour les conversions image, si GeoTiff, distinguo fait dans class Tiff

@OlivGruwe
Transformer Implementation
07a27e7
@OlivGruwe
Transformer Implementation
3c1ef15
@OlivGruwe
Transformer Implementation +
6d23b4c 
Direct Links in job output +
makefile +
tests
@OlivGruwe
Transformer Implementation
d85aa30 
Testing transformer engine added
@OlivGruwe
Transformer Implementation
b02bb01 
Remove requirements-trfm
Add to main requirements
@OlivGruwe
Transformer Implementation
d7c727f 
Why not pandas
@OlivGruwe
Transformer Implementation
b3b4f52 
Update requirements
@OlivGruwe
Correction Txt -> Pdf
dcde84e 
Ajout Multi frame Images
@github-actions github-actions bot added ci/doc Issue related to documentation of the package ci/operations Related to CI operations (actions, execution, install, builds, etc.) ci/tests Tests of the package and features feature/oas Issues related to OpenAPI specifications. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support labels Aug 9, 2023
fmigneault
fmigneault requested changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few linting issues that can be resolved automatically using the make fix[...] targets.
Validate as well using make check[...] targets any other flagged issues that might need some manual adjustments. I didn't comment on all of them.

I did not go in depth into the actual implementation of the transform functions.
I think there is a few tests missing to validate that the actual results from each transformation is valid (eg: pixel values from one format to another are properly rendered or expected text from one format to another is properly structured).

Makefile Outdated Show resolved Hide resolved
tests/smoke/docker-compose.smoke-test.yml Outdated Show resolved Hide resolved
tests/wps_restapi/test_jobs.py
# noqa: E241,E501
(uri_provider_jobs, Visibility.PUBLIC, self.user_admin_id, filter_service(public_jobs)), # noqa: E241,E501

] # type: List[Tuple[str, str, Union[None, int], List[Job]]]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert auto-formating by your IDE here and above.

tests/transform/test_tranform.py Outdated Show resolved Hide resolved
weaver/formats.py Outdated Show resolved Hide resolved
weaver/processes/builtin/__init__.py Outdated Show resolved Hide resolved
weaver/wps_restapi/jobs/jobs.py Outdated Show resolved Hide resolved
weaver/tranform/png2svg.py Outdated Show resolved Hide resolved
weaver/tranform/tiff.py Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add missing docstrings and typings.

weaver/tranform/transform.py Outdated Show resolved Hide resolved
This was referenced Sep 13, 2024
Open
Open
@github-actions github-actions bot added feature/job Issues related to job execution, reporting and logging. feature/quotation Issues related to quotation, billing and estimators. process/builtin Issue related to builtin application processes labels Sep 24, 2024
@Nazim-crim Nazim-crim self-assigned this Sep 24, 2024
@github-actions github-actions bot added the feature/cli Issues or features related to CLI operations. label Sep 25, 2024
@fmigneault fmigneault mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmigneault fmigneault fmigneault requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Nazim-crim Nazim-crim

Labels
ci/doc Issue related to documentation of the package ci/operations Related to CI operations (actions, execution, install, builds, etc.) ci/tests Tests of the package and features feature/cli Issues or features related to CLI operations. feature/job Issues related to job execution, reporting and logging. feature/oas Issues related to OpenAPI specifications. feature/quotation Issues related to quotation, billing and estimators. process/builtin Issue related to builtin application processes process/wps3 Issue related to WPS 3.x (REST-JSON) processes support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support the various formats that can represent a GeoTIFF Support /results/{id} and /outputs/{id} routes
3 participants
@OlivGruwe @fmigneault @Nazim-crim