Fix #4498: Strip File objects from messages when multimodal is unsupported

lib/crewai/src/crewai/llm.py

@@ -1978,22 +1978,33 @@ def _process_message_files(self, messages: list[LLMMessage]) -> list[LLMMessage]
         For each message with a `files` field, formats the files into
         provider-specific content blocks and updates the message content.
 
+        Always strips the ``files`` key so that non-serializable objects
+        never leak into the API payload.
+
         Args:
             messages: List of messages that may contain file attachments.
 
         Returns:
             Messages with files formatted into content blocks.
         """
-        if not HAS_CREWAI_FILES or not self.supports_multimodal():
-            return messages
-
-        provider = getattr(self, "provider", None) or self.model
+        can_process = HAS_CREWAI_FILES and self.supports_multimodal()
 
         for msg in messages:
             files = msg.get("files")
             if not files:
                 continue
 
+            if not can_process:
+                logging.warning(
+                    "Files were attached to a message but the model does not "
+                    "support multimodal input or crewai-files is not installed. "
+                    "The files have been dropped from the request."
+                )
+                msg.pop("files", None)
+                continue
+
+            provider = getattr(self, "provider", None) or self.model
+
             content_blocks = format_multimodal_content(files, provider)
             if not content_blocks:
                 msg.pop("files", None)
@@ -2020,22 +2031,33 @@ async def _aprocess_message_files(
         For each message with a `files` field, formats the files into
         provider-specific content blocks and updates the message content.
 
+        Always strips the ``files`` key so that non-serializable objects
+        never leak into the API payload.
+
         Args:
             messages: List of messages that may contain file attachments.
 
         Returns:
             Messages with files formatted into content blocks.
         """
-        if not HAS_CREWAI_FILES or not self.supports_multimodal():
-            return messages
-
-        provider = getattr(self, "provider", None) or self.model
+        can_process = HAS_CREWAI_FILES and self.supports_multimodal()
 
         for msg in messages:
             files = msg.get("files")
             if not files:
                 continue
 
+            if not can_process:
+                logging.warning(
+                    "Files were attached to a message but the model does not "
+                    "support multimodal input or crewai-files is not installed. "
+                    "The files have been dropped from the request."
+                )
+                msg.pop("files", None)
+                continue
+
+            provider = getattr(self, "provider", None) or self.model
+
             content_blocks = await aformat_multimodal_content(files, provider)
             if not content_blocks:
                 msg.pop("files", None)

lib/crewai/src/crewai/llms/base_llm.py

@@ -595,26 +595,37 @@ def _process_message_files(self, messages: list[LLMMessage]) -> list[LLMMessage]
         For each message with a `files` field, formats the files into
         provider-specific content blocks and updates the message content.
 
+        Always strips the ``files`` key so that non-serializable objects
+        never leak into the API payload.
+
         Args:
             messages: List of messages that may contain file attachments.
 
         Returns:
             Messages with files formatted into content blocks.
         """
-        if not HAS_CREWAI_FILES or not self.supports_multimodal():
-            return messages
-
-        provider = getattr(self, "provider", None) or getattr(self, "model", "openai")
-        api = getattr(self, "api", None)
+        can_process = HAS_CREWAI_FILES and self.supports_multimodal()
 
         for msg in messages:
             files = msg.get("files")
             if not files:
                 continue
 
+            if not can_process:
+                logging.warning(
+                    "Files were attached to a message but the model does not "
+                    "support multimodal input or crewai-files is not installed. "
+                    "The files have been dropped from the request."
+                )
+                msg.pop("files", None)
+                continue
+
             existing_content = msg.get("content", "")
             text = existing_content if isinstance(existing_content, str) else None
 
+            provider = getattr(self, "provider", None) or getattr(self, "model", "openai")
+            api = getattr(self, "api", None)
+
             content_blocks = format_multimodal_content(
                 files, provider, api=api, prefer_upload=self.prefer_upload, text=text
             )

lib/crewai/tests/llms/test_multimodal.py

@@ -1,13 +1,16 @@
 """Unit tests for LLM multimodal functionality across all providers."""
 
+import asyncio
 import base64
+import json
+import logging
 import os
 from unittest.mock import patch
 
 import pytest
 
 from crewai.llm import LLM
-from crewai_files import ImageFile, PDFFile, TextFile, format_multimodal_content
+from crewai_files import File, ImageFile, PDFFile, TextFile, format_multimodal_content
 
 # Check for optional provider dependencies
 try:
@@ -372,4 +375,168 @@ def test_format_empty_files_dict(self) -> None:
 
         result = format_multimodal_content({}, llm.model)
 
-        assert result == []
+        assert result == []
+
+
+class TestFilesStrippedWhenMultimodalUnsupported:
+    """Tests that File objects are always stripped from messages before API call.
+
+    Regression tests for https://github.com/crewAIInc/crewAI/issues/4498
+    TypeError: Object of type File is not JSON serializable
+    """
+
+    def test_base_llm_strips_files_when_multimodal_not_supported(self) -> None:
+        """BaseLLM._process_message_files must remove files when multimodal is off."""
+        from crewai.llms.base_llm import BaseLLM
+
+        class NonMultimodalLLM(BaseLLM):
+            def call(self, messages, tools=None, callbacks=None):
+                return "test"
+
+        llm = NonMultimodalLLM(model="test-no-multimodal")
+        assert llm.supports_multimodal() is False
+
+        messages = [
+            {
+                "role": "user",
+                "content": "Describe this file",
+                "files": {"doc": File(source=MINIMAL_PDF)},
+            }
+        ]
+
+        result = llm._process_message_files(messages)
+
+        assert "files" not in result[0]
+        assert result[0]["content"] == "Describe this file"
+
+    def test_base_llm_strips_files_logs_warning(self, caplog) -> None:
+        """BaseLLM logs a warning when dropping files on non-multimodal models."""
+        from crewai.llms.base_llm import BaseLLM
+
+        class NonMultimodalLLM(BaseLLM):
+            def call(self, messages, tools=None, callbacks=None):
+                return "test"
+
+        llm = NonMultimodalLLM(model="test-no-multimodal")
+        messages = [
+            {
+                "role": "user",
+                "content": "Describe this",
+                "files": {"img": ImageFile(source=MINIMAL_PNG)},
+            }
+        ]
+
+        with caplog.at_level(logging.WARNING):
+            llm._process_message_files(messages)
+
+        assert any("dropped from the request" in r.message for r in caplog.records)
+
+    def test_litellm_strips_files_when_multimodal_not_supported(self) -> None:
+        """LLM (litellm wrapper) strips files for non-multimodal models."""
+        llm = LLM(model="gpt-3.5-turbo", is_litellm=True)
+        assert llm.supports_multimodal() is False
+
+        messages = [
+            {
+                "role": "user",
+                "content": "Describe this file",
+                "files": {"doc": File(source=MINIMAL_PDF)},
+            }
+        ]
+
+        result = llm._process_message_files(messages)
+
+        assert "files" not in result[0]
+        assert result[0]["content"] == "Describe this file"
+
+    def test_litellm_async_strips_files_when_multimodal_not_supported(self) -> None:
+        """LLM async path strips files for non-multimodal models."""
+        llm = LLM(model="gpt-3.5-turbo", is_litellm=True)
+        assert llm.supports_multimodal() is False
+
+        messages = [
+            {
+                "role": "user",
+                "content": "Describe this file",
+                "files": {"doc": File(source=MINIMAL_PDF)},
+            }
+        ]
+
+        loop = asyncio.new_event_loop()
+        try:
+            result = loop.run_until_complete(
+                llm._aprocess_message_files(messages)
+            )
+        finally:
+            loop.close()
+
+        assert "files" not in result[0]
+        assert result[0]["content"] == "Describe this file"
+
+    def test_openai_native_strips_files_when_multimodal_not_supported(self) -> None:
+        """OpenAI native provider strips files for non-vision models."""
+        llm = LLM(model="openai/gpt-3.5-turbo")
+        assert llm.supports_multimodal() is False
+
+        messages = [
+            {
+                "role": "user",
+                "content": "Describe this file",
+                "files": {"doc": File(source=MINIMAL_PDF)},
+            }
+        ]
+
+        result = llm._process_message_files(messages)
+
+        assert "files" not in result[0]
+
+    def test_messages_are_json_serializable_after_file_stripping(self) -> None:
+        """After _process_message_files, messages must be JSON serializable."""
+        llm = LLM(model="gpt-3.5-turbo", is_litellm=True)
+
+        messages = [
+            {
+                "role": "user",
+                "content": "Analyze this",
+                "files": {"my_file": File(source=MINIMAL_PDF)},
+            }
+        ]
+
+        result = llm._process_message_files(messages)
+
+        json.dumps(result)
+
+    def test_multiple_messages_all_stripped(self) -> None:
+        """All messages with files get stripped, not just the first."""
+        llm = LLM(model="gpt-3.5-turbo", is_litellm=True)
+
+        messages = [
+            {
+                "role": "user",
+                "content": "First",
+                "files": {"a": File(source=MINIMAL_PDF)},
+            },
+            {
+                "role": "user",
+                "content": "Second",
+                "files": {"b": ImageFile(source=MINIMAL_PNG)},
+            },
+        ]
+
+        result = llm._process_message_files(messages)
+
+        for msg in result:
+            assert "files" not in msg
+
+    def test_messages_without_files_unchanged(self) -> None:
+        """Messages without files are not modified."""
+        llm = LLM(model="gpt-3.5-turbo", is_litellm=True)
+
+        messages = [
+            {"role": "user", "content": "Hello"},
+            {"role": "assistant", "content": "Hi"},
+        ]
+
+        result = llm._process_message_files(messages)
+
+        assert result == messages