feat: frontend improvements and updates#928
Merged
hyacinthus merged 9 commits intomainfrom Dec 27, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 21 out of 24 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (9)
app/admin/api.py:77
- This comment appears to contain commented-out code.
# if not input.owner:
# raise IntentKitAPIError(
# status_code=400, key="BadRequest", message="Owner is required"
app/admin/api.py:85
- This comment appears to contain commented-out code.
# if user_id:
# if input.owner != user_id:
# raise IntentKitAPIError(
# status_code=400,
# key="BadRequest",
# message="Owner does not match user ID",
app/admin/api.py:92
- This comment appears to contain commented-out code.
# if user:
# max_fee += user.nft_count * 10
# if input.fee_percentage and input.fee_percentage > max_fee:
# raise IntentKitAPIError(
# status_code=400, key="BadRequest", message="Fee percentage too high"
app/admin/api.py:127
- This comment appears to contain commented-out code.
# if not input.owner:
# raise IntentKitAPIError(
# status_code=400, key="BadRequest", message="Owner is required"
app/admin/api.py:135
- This comment appears to contain commented-out code.
# if user_id:
# if input.owner != user_id:
# raise IntentKitAPIError(
# status_code=400,
# key="BadRequest",
# message="Owner does not match user ID",
app/admin/api.py:142
- This comment appears to contain commented-out code.
# if user:
# max_fee += user.nft_count * 10
# if input.fee_percentage and input.fee_percentage > max_fee:
# raise IntentKitAPIError(
# status_code=400, key="BadRequest", message="Fee percentage too high"
app/admin/credit.py:122
- This comment appears to contain commented-out code.
# class AdjustmentRequest(BaseModel):
# """Request model for adjusting a user account."""
# upstream_tx_id: Annotated[
# str, Field(str, description="Upstream transaction ID, idempotence Check")
# ]
# user_id: Annotated[str, Field(description="ID of the user to adjust")]
# credit_type: Annotated[CreditType, Field(description="Type of credit to adjust")]
# amount: Annotated[
# Decimal, Field(description="Amount to adjust (positive or negative)")
# ]
# note: Annotated[str, Field(description="Required explanation for the adjustment")]
intentkit/models/chat.py:385
- This method requires 1 positional argument, whereas overridden ChatMessageCreate.lambda requires 0.
datetime: lambda v: v.isoformat(timespec="milliseconds"),
intentkit/models/chat.py:562
- This method requires 1 positional argument, whereas overridden ChatCreate.lambda requires 0.
json_encoders={datetime: lambda v: v.isoformat(timespec="milliseconds")},
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # Get the latest agent from create_or_update | ||
| latest_agent, agent_data = await deploy_agent(agent_id, agent, subject) | ||
| latest_agent, agent_data = await deploy_agent(agent_id, agent, "admin") |
There was a problem hiding this comment.
Variable latest_agent is not used.
|
|
||
| # Get the latest agent from create_or_update | ||
| latest_agent, agent_data = await deploy_agent(agent_id, agent, subject) | ||
| latest_agent, agent_data = await deploy_agent(agent_id, agent, "admin") |
There was a problem hiding this comment.
Variable agent_data is not used.
Suggested change
| latest_agent, agent_data = await deploy_agent(agent_id, agent, "admin") | |
| await deploy_agent(agent_id, agent, "admin") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes: