Add skill for deck of cards API#538
Closed
Deeptanshu-sankhwar wants to merge 6 commits intocrestalnetwork:mainfrom
Closed
Add skill for deck of cards API#538Deeptanshu-sankhwar wants to merge 6 commits intocrestalnetwork:mainfrom
Deeptanshu-sankhwar wants to merge 6 commits intocrestalnetwork:mainfrom
Conversation
Collaborator
|
Thank you for the interesting idea. I understand you want to load all the skills holistically, but due to some non-core limitations, we currently must list all skills in the config. Here are two methods to consider:
The second option seems slightly better. |
hyacinthus
requested changes
May 15, 2025
|
|
||
|
|
||
| class SkillStates(TypedDict): | ||
| shuffle_deck: SkillState |
Collaborator
There was a problem hiding this comment.
Or maybe you just missing others here?
| name = "draw_cards" | ||
| description = "Draw a specified number of cards from a deck" | ||
|
|
||
| async def _arun(self, deck_id: str, count: int = 1) -> str: |
Collaborator
There was a problem hiding this comment.
If there are parameters, you need to declare them in args_schema; otherwise, the AI will not call it. It seems there are still many problems; please complete it and pass the local test.
Contributor
|
Closing this PR since it's been inactive for a while and improvements have been made elsewhere. Happy to reopen it later if needed. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added the skill for deck of cards API with the following features
shuffle_deck()— Initialize and shuffle a full deck.draw_cards(deck_id, count)— Draw X number of cards.add_to_pile(deck_id, pile_name, cards)— Add cards to a named pile.draw_from_pile(deck_id, pile_name)— Draw cards from a named pile.list_piles(deck_id)— View existing piles and contents.Type of Change
Checklist
Related Issue
Closes #526