Version 2? #209
Version 2? #209
Conversation
On phpunit9 assertRegExp is deprecated. I can't use phpunit9, which is not compatible with php7.2
File test renamed
|
@tugrul this commit removes This travis build is corresponding to the last commit. As you can see, all build jobs are "green". |
|
@Alexandre-T |
|
@sadortun Is there anything else blocking the merge? |
|
@djlambert @Alexandre-T I really appreciate the time and effort you put in, and we will merge this soon!. @djlambert Just to make sure we dont cause a major panic out there, I want your opnion on this. Since this PR might include BC breaks. it should be bumped to a next major version tag, that prety obvious. But i can see an issue where folks are using Here the steps i propose :
Will this cause issues with other @creof libraries ? We probably need a quick note in @Alexandre-T We probably need, if not already done, update the |
| public function getSrid() | ||
| { | ||
| return $this->srid; | ||
| return json_encode($json); |
There was a problem hiding this comment.
return json_encode($this); same output because class implements JsonSerializable
There was a problem hiding this comment.
I added JsonSerializable because I read #194 , but (I'm not sure) I encountered an error in a specific case. Do you agree to wait this PR to be merged, then I will try it another time.
There was a problem hiding this comment.
@Alexandre-T JsonSerializable is good. I just mention that no need to create array to generate json from toJson function.
following function will be enough because JsonSerializable feature in use.
public function toJson()
{
return json_encode($this);
}
|
I do agree with your four steps. What do you think about creating a 1.3.x-dev tag instead of a 1.x-dev? Changelog is already done. I could update the readme to add a small paragraph to avoid panic for developers using dev-master. |
| ### MariaDB 10 | ||
| This version is **NOT** compatible with MariaDB version. Some spatial functions seems to work but their results are | ||
| different from MySQL version (StContains function is a good example). You can contribute, but I suggest to avoid | ||
| MySql and MariaDb servers, because of [their shortcomings and vulnerabilities](https://sqlpro.developpez.com/tutoriel/dangers-mysql-mariadb/). |
There was a problem hiding this comment.
The link to the article should be removed. Because it is a subjective opinion about RDBMS choice (expressed in a rather aggressive tone) and has no reason to be mentioned here. It also happens to be in French which most readers might not be able to read. And finally the way it is introduced make it looks like it is about MariaDB only, but it actually is about both MySQL and MariaDB.
As a matter of fact, the whole "Compatibility" section here is a bit confusing. Topics are mixed between "Compatibility between this lib and a RDBMS" and "Compatibility across RDBMS". The fact that StContains returns different result between MySQL and MariaDB does not make this lib incompatible with MariaDB.
|
Any news about this fix or some fork that fix it? I'm getting the same error after upgrating to PHP 8. |
|
nevermind, I see that @Alexandre-T created a new one. Thank you! |
|
For the records, @rogeriolino was referring to the fork of @Alexandre-T that is available there: https://github.com/Alexandre-T/doctrine2-spatial |
|
I created an organization named LongitudeOne and a new package that will replace and maintain this awesome spatial extension. All improvements from this PR are already included. I published a pre-released which is compatible with PHP8, MySQL5.7, MySQL8, PostgreSQL13 and PostGis 3.1. |
|
@Alexandre-T we have a lot of people using this extension, if you want to volunteer as a maintainer, we can simply add you here so everybody can use your updates |
|
I just realize you've been working on this for the past year and I really appreciate your contributions. Let me do what I mentioned #209 (comment) And I'll be ready to merge this PR as. |
|
Is there an idea of when a new version of this package might be released. I've been (happily) using Thanks for working on all this! It's super useful. |
|
I marked it abandoned, because I replaced it by this one: https://github.com/longitude-one/doctrine-spatial |
Hi,
I needed a new version of doctrine2-spatial which is compatible with PHP 7.2+. So I forked your excellent library and updated it. Because of a lot of changes between PHP 5.1 and PHP 7, my updates do NOT warranty backward compatibility. So, if you're agree to merge my pull-request in your repository, you're welcomed, but do not forget that you should create a new major version.
All new features are described in the Changelog file. There is a new documentation. Please, forgive me, I'm not fluent in english.
If you merge it, I will update the documentation to replace references to my package
alexandret/doctrine2-spatialby yours.You can find the travis, code climat and code coverage results here :
Alexandre